[Bug 226443] Merge Review: switchdesk

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226443

Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #8 from Jussi Lehtola <jussi.lehtola at iki.fi> 2010-07-07 11:12:50 EDT ---
MUST:
- Desktop-file-validate must be run in %install, not in %check. See
http://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage

- The source URL works now, but is this a long-term solution? The sources
should be moved to fedorahosted.org.

SHOULD:
- I usually like a bit more verbosity in %files; statements such as 
 %{_bindir}/*
and
 %{_mandir}/man1/*
can be a bit dangerous. You can easily fix this by changing them into
 %{_bindir}/%{name}*
and
 %{_mandir}/man1/%{name}*


The remaining issues are cosmetic. Please fix at least the MUST items before a
cvs push. This package has been

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.