[Bug 456353] Review Request: libffado - Free firewire audio driver library

bugzilla at redhat.com bugzilla at redhat.com
Thu Jul 8 04:53:02 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456353

--- Comment #25 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com> 2010-07-08 00:53:01 EDT ---
Thanks!

(In reply to comment #24)
> > ffado.x86_64: W: no-documentation
> > ffado.x86_64: W: no-manual-page-for-binary ffado-diag
> > ffado.x86_64: W: no-manual-page-for-binary ffado-fireworks-downloader
> > ffado.x86_64: W: no-manual-page-for-binary ffado-mixer
> > ffado.x86_64: W: no-manual-page-for-binary ffado-dbus-server
> > ffado.x86_64: W: no-manual-page-for-binary ffado-bridgeco-downloader
> 
> some documentation would be nice.  not even a basic list of "this program does
> <this>" exists.
> 

Yeah. I'll do what every good packager should do. Steal it from Deb... uhm, I
mean ask upstream.

> 
> > libffado.x86_64: W: shared-lib-calls-exit /usr/lib64/libffado.so.2.999.0 exit at GLIBC_2.2.5
> 
> explanation?
> 

I searched for this one but couldn't find the exit() call with a grep. Maybe it
gets in via some weird #include. I'll dig further. Let me know if you can find
it.

> > libffado-devel.x86_64: W: spurious-executable-perm /usr/share/doc/libffado-devel-2.0.1/tests/dbus_test.py
> > libffado-devel.x86_64: W: doc-file-dependency /usr/share/doc/libffado-devel-2.0.1/tests/dbus_test.py /usr/bin/python
> 
> seems a bit strange as a %doc?    

What is the best place to put these? Is %{_datadir}/%{name} good?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list