[Bug 226440] Merge Review: subversion

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226440

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |panemade at gmail.com
               Flag|                            |needinfo?(jgarzik at redhat.co
                   |                            |m)

--- Comment #5 from Parag AN(पराग) <panemade at gmail.com> 2010-07-08 05:33:06 EDT ---
Jeff,

1)   If you was not triaging this bug, if you are not reviewing this package
and assuming you are maintaining this package, will you please fix following
rpmlint messages?

subversion.src: W: strange-permission filter-requires.sh 0775L
subversion.src:7: E: hardcoded-library-path in /usr/lib/jvm/java
subversion.src:222: E: use-of-RPM_SOURCE_DIR
subversion.src: W: patch-not-applied Patch6: subversion-1.6.0-pie.patch


subversion.x86_64: E: wrong-script-end-of-line-encoding
/usr/share/doc/subversion-1.6.12/tools/buildbot/slaves/i686-debian-sarge1/svnlog.sh
subversion.x86_64: E: wrong-script-end-of-line-encoding
/usr/share/doc/subversion-1.6.12/tools/buildbot/slaves/i686-debian-sarge1/svnclean.sh
subversion.x86_64: E: wrong-script-end-of-line-encoding
/usr/share/doc/subversion-1.6.12/tools/buildbot/slaves/osx10.4-gcc4.0.1-ia32/svnbuild.sh
subversion.x86_64: E: wrong-script-end-of-line-encoding
/usr/share/doc/subversion-1.6.12/tools/buildbot/slaves/osx10.4-gcc4.0.1-ia32/svncheck.sh
subversion.x86_64: E: wrong-script-end-of-line-encoding
/usr/share/doc/subversion-1.6.12/tools/buildbot/slaves/i686-debian-sarge1/svnbuild.sh
subversion.x86_64: E: wrong-script-end-of-line-encoding
/usr/share/doc/subversion-1.6.12/tools/buildbot/slaves/osx10.4-gcc4.0.1-ia32/svnlog.sh
subversion.x86_64: E: wrong-script-end-of-line-encoding
/usr/share/doc/subversion-1.6.12/tools/buildbot/slaves/i686-debian-sarge1/svncheck.sh
subversion.x86_64: E: wrong-script-end-of-line-encoding
/usr/share/doc/subversion-1.6.12/tools/buildbot/slaves/osx10.4-gcc4.0.1-ia32/svnclean.sh


subversion-gnome.x86_64: E: library-without-ldconfig-postin
/usr/lib64/libsvn_auth_gnome_keyring-1.so.0.0.0
subversion-gnome.x86_64: E: library-without-ldconfig-postun
/usr/lib64/libsvn_auth_gnome_keyring-1.so.0.0.0
subversion-kde.x86_64: E: library-without-ldconfig-postin
/usr/lib64/libsvn_auth_kwallet-1.so.0.0.0
subversion-kde.x86_64: E: library-without-ldconfig-postun
/usr/lib64/libsvn_auth_kwallet-1.so.0.0.0


2) I am not sure why you need both python and python-devel as BuildRequires:
as per https://fedoraproject.org/wiki/Packaging/Python, you should change it to 

BuildRequires: python2-devel 

3) you don't need following in spec as per guidelines.
%{!?python_sitearch: %define python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib(1)")}

3) you don't need perl macro as its not included in /usr/lib/rpm/macros.perl
drop following line
%define perl_vendorarch %(eval "`%{__perl} -V:installvendorarch`"; echo
$installvendorarch)

4) Drop Buildroot tag, %clean section and cleaning of buildroot in %install in
devel branch as its not needed now.

Note: This is not complete review, just initial comments.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.