[Bug 226222] Merge Review: oprofile

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226222

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Reopened
             Status|CLOSED                      |ASSIGNED
                 CC|                            |panemade at gmail.com
         Resolution|CURRENTRELEASE              |

--- Comment #3 from Parag AN(पराग) <panemade at gmail.com> 2010-07-08 06:46:40 EDT ---
Hi Jeff,
  Can you please fix following issues and build new oprofile in rawhide?

1) Use macros as per https://fedoraproject.org/wiki/Packaging:RPMMacros
Replace /etc occurrences with %{_sysconfdir} 
Replace /usr/share occurrences with %{_datadir} 

2) mixing of macro style should be avoided
you have used %{buildroot} and $RPM_BUILD_ROOT. See
https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

3) Good if you will change
make DESTDIR=${RPM_BUILD_ROOT} install
to
make install DESTDIR=${RPM_BUILD_ROOT} INSTALL="install -p"

also add -p to all install commands 

This will make sure keeping upstream timestamps.

4)Buildroot is not required,%clean is not needed, remove cleaning of buildroot
in %install.

5) see https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net and
add source url as
Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz

6) Drop 
BuildRequires: binutils-devel
as this will get pulled by binutils-static

7) see
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries
and drop 

Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig
Requires: /etc/ld.so.conf.d

8)Good to fix following rpmlint output messages (Included only messages that
need to be fixed)

oprofile.src:21: W: macro-in-comment %{ix86}
oprofile.src:21: W: macro-in-comment %{arm}
oprofile.src:136: W: macro-in-comment %doc
oprofile.src:144: W: macro-in-comment %{_includedir}
oprofile.src:157: W: macro-in-comment %{_libdir}
oprofile.src: W: patch-not-applied Patch83: oprofile-0.9.3-xen.patch
oprofile.src: W: invalid-url Source0: oprofile-0.9.6.tar.gz
oprofile-devel.x86_64: W: summary-ended-with-dot C Header files and libraries
for developing apps which will use oprofile.
oprofile-devel.x86_64: W: spurious-executable-perm /usr/lib64/libopabi.a
oprofile-devel.x86_64: W: spurious-executable-perm /usr/include/op_list.h
oprofile-devel.x86_64: W: spurious-executable-perm
/usr/include/op_sample_file.h
oprofile-devel.x86_64: W: spurious-executable-perm /usr/include/op_config.h
oprofile-devel.x86_64: W: spurious-executable-perm /usr/lib64/liboputil.a
oprofile-devel.x86_64: W: spurious-executable-perm /usr/include/odb.h
oprofile-devel.x86_64: W: spurious-executable-perm /usr/include/op_types.h
oprofile-devel.x86_64: W: spurious-executable-perm /usr/lib64/libop.a
oprofile-devel.x86_64: W: spurious-executable-perm /usr/include/op_cpu_type.h
oprofile-devel.x86_64: W: spurious-executable-perm /usr/lib64/liboputil++.a
oprofile-devel.x86_64: W: spurious-executable-perm /usr/lib64/libodb.a
oprofile-devel.x86_64: W: spurious-executable-perm /usr/include/op_events.h
oprofile-gui.x86_64: W: summary-ended-with-dot C GUI for oprofile.

oprofile-jit.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/oprofile/libopagent.a
oprofile-jit.x86_64: W: non-conffile-in-etc
/etc/ld.so.conf.d/oprofile-x86_64.conf
oprofile-jit.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/oprofile/libjvmti_oprofile.a
oprofile-jit.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/oprofile/libjvmti_oprofile.so
oprofile-jit.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/oprofile/libopagent.so

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.