[Bug 226439] Merge Review: stunnel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226439

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
               Flag|                            |needinfo?

--- Comment #4 from Parag AN(पराग) <panemade at gmail.com> 2010-07-08 06:50:37 EDT ---

1) It will be good to drop buildroot instead have wrong buildroot as in F-13 we
don't need it now.

Also, no %clean section is needed and no cleaning of buildroot in %install

2) install commands should use -p to preserve timestamps. Good if you will
change
make DESTDIR=${RPM_BUILD_ROOT} install
to
make install DESTDIR=${RPM_BUILD_ROOT} INSTALL="install -p"

3) rpmlint reported

stunnel.x86_64: W: manual-page-warning /usr/share/man/man8/stunnel.8.gz 76:
warning: can't find numbered character 160
This man page may contain problems that can cause it not to be formatted as
intended.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.