[Bug 594414] Review Request: ezmorph - Object transformation library for Java
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jul 8 12:45:21 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=594414
Stanislav Ochotnicky <sochotni at redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sochotni at redhat.com
--- Comment #6 from Stanislav Ochotnicky <sochotni at redhat.com> 2010-07-08 08:45:20 EDT ---
rpmlint was mostly OK (package is missing any LICENSE file though...not a fatal
error but should be fixed with upstream).
There are a few issues though:
* Please provide real reason for using CVS instead of release tarball. It
might be funny, but once someone else starts maintaining this they will not
know why it's there...
* Why are you patching pom.xml? The package builds fine without that patch1
* Package seems to be missing log4j as a Requires (see
http://ezmorph.sourceforge.net/dependencies.html)
* There was recent discussion on requiring javadoc subpackage to pull in main
package as well (perhaps someone wants just the docs?). This is of course
totally up to you, but you might consider replacing dependency on name =
version with jpackage-utils.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list