[Bug 456353] Review Request: libffado - Free firewire audio driver library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456353

--- Comment #26 from Jeff Garzik <jgarzik at redhat.com> 2010-07-08 18:09:18 EDT ---
(In reply to comment #25)
> (In reply to comment #24)
> > > libffado.x86_64: W: shared-lib-calls-exit /usr/lib64/libffado.so.2.999.0 exit at GLIBC_2.2.5
> > 
> > explanation?
> > 
> 
> I searched for this one but couldn't find the exit() call with a grep. Maybe it
> gets in via some weird #include. I'll dig further. Let me know if you can find
> it.

'nm src/libffado.so' seems to find at least one call to exit() in the area
where the following symbols are found:

00114d8f t csr1212_remove_cache
0011376a t csr1212_rom_cache_malloc
002d1484 b dtor_idx.5965
002d1464 d err_array_elem_type
002d1468 d err_duplicate_setting
         U exit@@GLIBC_2.0
0010604c t exitfunc
         U fabsf@@GLIBC_2.0
         U fclose@@GLIBC_2.1
         U ferror@@GLIBC_2.0
00106097 T ffado_get_api_version
00106081 T ffado_get_version
0014e604 T ffado_ringbuffer_create
0014e6b8 T ffado_ringbuffer_free
0014eb03 T ffado_ringbuffer_get_read_vector


> > > libffado-devel.x86_64: W: spurious-executable-perm /usr/share/doc/libffado-devel-2.0.1/tests/dbus_test.py
> > > libffado-devel.x86_64: W: doc-file-dependency /usr/share/doc/libffado-devel-2.0.1/tests/dbus_test.py /usr/bin/python
> > 
> > seems a bit strange as a %doc?    
> 
> What is the best place to put these? Is %{_datadir}/%{name} good?    

A more basic question, does it need to be shipped at all?  Unit tests are
typically run during the make-dist-tarball process upstream, and also, during
the Fedora package build process.

If the end user has no need for dbus_test.py (used for testing FFADO dbus
interface?), then why ship it?  We don't ship the gcc testsuite with the gcc
package, as documentation, for example.

If the end user does have a use for dbus_test.py, it seems that an
executable-binaries directory would be more appropriate.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.