[Bug 456353] Review Request: libffado - Free firewire audio driver library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456353

--- Comment #27 from Jeff Garzik <jgarzik at redhat.com> 2010-07-08 18:51:29 EDT ---
(category, pkg naming guidelines)

* Package version: instructions could be improved to describe how to produce
that exact commit and tarball shipped with the SRPM, rather than general
instructions about how the tarball was created when the snapshot was taken.

(category, pkg guidelines)

* The following seems to indicate your devel package needs some additional
Requires:
https://fedoraproject.org/wiki/Packaging:Guidelines#Requires

* "All patches in Fedora spec files SHOULD have a comment above them about
their upstream status."

(category, pkg/python, https://fedoraproject.org/wiki/Packaging:Python)

* "when building a package which ships python3 files, you need

BuildRequires: python3-devel"

(ditto for python2)

(category, review guidelines)

OK, seems to pass everything here, including test builds, though I'm unable to
actually test this due to lack of firewire audio hardware.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.