[Bug 456353] Review Request: libffado - Free firewire audio driver library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456353

--- Comment #29 from Jeff Garzik <jgarzik at redhat.com> 2010-07-08 22:49:35 EDT ---
(In reply to comment #28)
> I'll do the changes you asked, but I have two questions:
> 
> > 'nm src/libffado.so' seems to find at least one call to exit() in the area
> > where the following symbols are found:
> 
> I know that the exit() symbol is in the library. I just can't find what source
> file it originates from. Doesn't the U in 
>          U exit@@GLIBC_2.0
> mean "undefined"?

Correct.  Undefined, for that .o module.  'U' basically means an external
reference that was not found in the source code at compile time.  For example,
this C file

    #include <stdlib.h>
    #include <stdio.h>

    int foo(int blahbla)
    {
 printf("blahblah %d\n", blahbla);
 return 0;
    }

produces

    0000000000000000 T foo
                     U printf

thus "U exit@@GLIBC_2.0" is an external reference, and the symbols "close" to
it are typically found in the same .o file at link time as the external
reference... making that a clue to help you track down the area of code calling
exit(3).


> > * The following seems to indicate your devel package needs some additional
> > Requires:
> > https://fedoraproject.org/wiki/Packaging:Guidelines#Requires
> 
> Can you be more specific?
> 
> Thanks.    

This part:  "Typically, the requirements for -devel packages need yet another
look. They're not usually picked up automatically by rpm. [...] This means that
gtk+-devel should contain

     Requires: glib-devel libXi-devel libXext-devel libX11-devel"

For example, will building libffado applications require libiec61883-devel or
libraw1394-devel?  ffado.h appears to lack external dependencies, so I am
guessing the answer is "no."

But I just wanted to check and make sure.  If the answer is "no" this item can
be crossed off.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.