[Bug 612533] Review Request: qrencode - Generate QR 2D barcodes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=612533

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #3 from Parag AN(पराग) <panemade at gmail.com> 2010-07-09 01:44:06 EDT ---
Tareq,

1)any particular reason to create -libs subpackage?

2) You need to fix rpath issue as reported by rpmlint.
qrencode.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/qrencode
['/usr/lib64']

see http://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath
and add following to %prep section
sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool
sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool

3) Good if you will use
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

This will preserve the timestamps of files being copied from upstream tarball
in rpm.

4) License looks to me LGPLv2+. All the source files *.c and *.h includes
header for LGPLv2+ license.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.