[Bug 565251] Review Request: coan - A commandline tool for simplifying the preprocessor conditionals in source code

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565251

Ankur Sinha <sanjay.ankur at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #11 from Ankur Sinha <sanjay.ankur at gmail.com> 2010-07-09 03:36:48 EDT ---
Looks good. Issues have been corrected.

Builds on F13, rpmlint gives minor warnings (spelling suggestions that can be
ignored):

[Ankur at localhost SPECS]$ rpmlint ../RPMS/x86_64/coan-* coan.spec
../SRPMS/coan-4.1-2.fc13.src.rpm 
coan.x86_64: W: spelling-error Summary(en_US) commandline -> command line,
command-line, commanding
coan.x86_64: W: spelling-error Summary(en_US) preprocessor -> preprocessed,
processor, preprofessional
coan.x86_64: W: spelling-error %description -l en_US analysing -> analyzing,
analysis, analysand
coan.x86_64: W: spelling-error %description -l en_US preprocessor ->
preprocessed, processor, preprofessional
coan.x86_64: W: spelling-error %description -l en_US unifdef -> unifier,
unifiable, uniform
coan.x86_64: W: spelling-error %description -l en_US sunifdef -> sundries,
sunshade, sunniness
coan.x86_64: W: spelling-error Summary(en_US) preprocessor -> preprocessed,
processor, preprofessional
coan.x86_64: W: spelling-error %description -l en_US preprocessor ->
preprocessed, processor, preprofessional
coan.x86_64: W: spelling-error %description -l en_US unifdef -> unifier,
unifiable, uniform
coan.x86_64: W: spelling-error %description -l en_US sunifdef -> sundries,
sunshade, sunniness
coan.spec: W: invalid-url Source0:
http://downloads.sourceforge.net/coan2/v4.1/coan-4.1.tar.gz <urlopen error
timed out>
coan.src: W: spelling-error Summary(en_US) preprocessor -> preprocessed,
processor, preprofessional
coan.src: W: spelling-error %description -l en_US preprocessor -> preprocessed,
processor, preprofessional
coan.src: W: spelling-error %description -l en_US unifdef -> unifier,
unifiable, uniform
coan.src: W: spelling-error %description -l en_US sunifdef -> sundries,
sunshade, sunniness
coan.src: W: invalid-url Source0:
http://downloads.sourceforge.net/coan2/v4.1/coan-4.1.tar.gz <urlopen error
timed out>
5 packages and 1 specfiles checked; 0 errors, 16 warnings.


Do change "commandline" to "command line" when you push it to the repos though. 

XXX APPROVED XXX

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.