[Bug 607389] Review Request: felix-osgi-compendium - Felix OSGi R4 Compendium Bundle

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=607389

--- Comment #3 from Victor G. Vasilyev <victor.vasilyev at sun.com> 2010-07-09 15:02:49 EDT ---
(In reply to comment #2)
> Could you switch to using maven instead of ant?
Fixed 
> Also javadoc subpackage is missing post/postun for jpackage-utils.
Fixed: "Requires: jpackage-utils" is added for the javadoc subpackage.
> Instead of "{_datadir}/maven2/poms/" you can use "{_mavenpomdir}".
Fixed
> Other than that package seems OK and rpmlint is clean.
Now, rpmlint report is really clean. 
It shows  "0 errors, 0 warnings" for all RPMs, including src.rpm.

Note, in the section %files the following statement is used to avoid an rpmlint
warning:
%config(noreplace) %{_mavendepmapfragdir}/%{name}    

I hope, it is a correct solution for our purposes.
See also the errata (page 50) here: http://foster-johnson.com/rpm.html 
where behavior of %config(noreplace) is explained.

BTW If it is really right solution then it could also be addressed to examples
of the spec files for maven projects that are published on Fedora's wiki pages.

The second release of the package is prepared for review:
SPEC: http://victorv.fedorapeople.org/files/felix-osgi-compendium.spec
SRPM:
http://victorv.fedorapeople.org/files/felix-osgi-foundation-1.2.0-2.fc14.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2309644

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.