[Bug 226299] Merge Review: pkgconfig

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226299

Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #16 from Jussi Lehtola <jussi.lehtola at iki.fi> 2010-07-09 15:54:04 EDT ---
Great, so the bundled glib has been removed. rpmlint output now stands at

pkgconfig.src: W: no-cleaning-of-buildroot %clean
pkgconfig.src: W: no-buildroot-tag
pkgconfig.src: W: no-%clean-section
pkgconfig.x86_64: W: incoherent-version-in-changelog 0.25-2 ['1:0.25-2.fc13',
'1:0.25-2']
pkgconfig.x86_64: W: devel-file-in-non-devel-package /usr/bin/pkg-config
pkgconfig.x86_64: W: manual-page-warning /usr/share/man/man1/pkg-config.1.gz
58: warning: `I/usr/lib/pkgconfig,' not defined
pkgconfig.x86_64: W: manual-page-warning /usr/share/man/man1/pkg-config.1.gz
60: warning: `I/usr/local/share/pkgconfig' not defined
pkgconfig.x86_64: W: manual-page-warning /usr/share/man/man1/pkg-config.1.gz
154: warning: `I.pc' not defined
pkgconfig.x86_64: W: manual-page-warning /usr/share/man/man1/pkg-config.1.gz
206: warning: `I-Lx:/some/path' not defined
3 packages and 0 specfiles checked; 0 errors, 9 warnings.

Here, the only relevant warning is the incoherent version; the changelog is
missing the epoch. You might want to have a look also at the man page stuff.

**

You should still add INSTALL="install -p" to make install, as some
non-generated files are losing their time stamps in install.

The defattr stuff was my misunderstanding - the current syntax is also OK.

The ChangeLog reads that it isn't kept up-to-date anymore, so there's no need
anymore to add it.

**

The remaining issues are cosmetic, please fix them in the next CVS push and
mark this bug as closed. This package has been

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.