[Bug 612224] Review Request: opencpn - An open source chart plotter/navigator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=612224

--- Comment #1 from Dan Horák <dan at danny.cz> 2010-07-10 09:04:46 EDT ---
some issues discovered before doing a formal review:
- use the standard macro for calling cmake -
https://fedoraproject.org/wiki/Packaging:Cmake
- explicit Requires are not needed, they will be filled in automatically by
rpmbuild
- the %{_datadir}/opencpn directory is not owned by the package, either add
%dir %{_datadir}/opencpn or use only %{_datadir}/opencpn as it will include all
subdirs into the package
- doesn't build in rawhide, I think the path for gdk-pixbuf2 includes is not
set, probably related to the recent move of gdk-pixbuf2 to its own package
- builds its own copy of bzip2 library, you must add BR: bzip2-devel
- includes (outdated) zlib headers, I would rather remove them before build to
be sure they are not used
- I would prefer to see each BR: on its own line, it's easier to track their
changes
- includes GDAL library (or parts only?) - a system copy must be used
- you probably want to add BR: gpsd-devel

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.