[Bug 608419] Review Request: perl-CGI-Application-FastCGI - For using CGI::Application under FastCGI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=608419

Iain Arnell <iarnell at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Iain Arnell <iarnell at gmail.com> 2010-07-11 03:22:21 EDT ---
+ source files match upstream.  
    c8812ed3d04a4d4e9233a9550c3862d2  CGI-Application-FastCGI-0.02.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
    GPL+ or Artistic

+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2310649

+ package installs properly.
+ rpmlint has no complaints:
    perl-CGI-Application-FastCGI.noarch: I: checking
    perl-CGI-Application-FastCGI.noarch: I: checking-url
http://search.cpan.org/dist/CGI-Application-FastCGI/ (timeout 10 seconds)
    perl-CGI-Application-FastCGI.src: I: checking
    perl-CGI-Application-FastCGI.src: I: checking-url
http://search.cpan.org/dist/CGI-Application-FastCGI/ (timeout 10 seconds)
    perl-CGI-Application-FastCGI.src: I: checking-url
http://www.cpan.org/authors/id/N/NA/NAOYA/CGI-Application-FastCGI-0.02.tar.gz
(timeout 10 seconds)
    2 packages and 0 specfiles checked; 0 errors, 0 warnings.

- final provides and requires are sane:
    perl(CGI::Application::FastCGI) = 0.02
    perl-CGI-Application-FastCGI = 0.02-1.fc14
=
    perl(base)  
    perl(CGI)  
    perl(FCGI)  
    perl(:MODULE_COMPAT_5.12.1)  
    perl(strict)  

+ %check is present and all tests pass.
    t/CGI-Application-FastCGI.t .. ok
    All tests successful.
    Files=1, Tests=1,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.04 cusr  0.01
csys =  0.07 CPU)
    Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


You need an explicit "Requires: perl(CGI::Application)" which isn't picked up
automatically due to "use base" construct. But otherwise, it's fine.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.