[Bug 610934] Review Request: go - The Google Go Programming Language

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=610934

--- Comment #6 from Michel Alexandre Salim <michael.silvanus at gmail.com> 2010-07-11 09:08:34 EDT ---
Brandon,

When updating for the new release, please do the following:

- for the clone instruction, instead of -r release, please use -r
release.2010-07-01 . This makes sure that the instruction would fetch the
correct source even after subsequent releases

(aside: kind of curious how the release.2010-07-01 tag does *not* appear in the
output of 'hg tags' until after I pull in some changes newer than the tag)

- use hg archive instead of invoking tar yourself. That would strip out the .hg
metadata, and for those who track the Go upstream repo (as you, me as the
reviewer, and any future co-maintainers likely do), it would avoid having to
clone a new copy every time a new release come out because the working tree has
been used for compilation. 

- if you're targeting only recent Fedora releases, consider using xz instead of
bzip2 for the archive compression.

hg archive -t tar ../go-20100701.tar
cd ..
xz -9e -k go-*.tar # -k only used so the .tar is kept for re-compressing
bzip2 --best -k go-*.tar
ls -l go*.tar*

$ ls -l go*.tar*
-rw-rw-r--. 1 michel michel 20541440 Jul 11 14:54 go-20100701.tar
-rw-rw-r--. 1 michel michel  4700747 Jul 11 14:54 go-20100701.tar.bz2
-rw-rw-r--. 1 michel michel  3762540 Jul 11 14:54 go-20100701.tar.xz

- Here's the Emacs packaging guideline. You'd want to byte-compile the *.el
files if possible, and only package the .elc files in the main Emacs
subpackage. The source *.el should be in a separate emacs-go-el subpackage.

- there seems to be a bug in the files section. Since 8* is generated on ix86,
and 6* on x86_64, you probably want

%ifarch %ix86
%{_bindir}/8*
%else
%{_bindir}/6*
%endif
... common filenames here ...

- you need to own %{_sysconfdir}/bash_completion.d 

- for Fedora 12 and above, BuildRoot no longer needs to be defined. For Fedora
13 and above, %clean is also no longer needed.
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

So depending on which distributions you want to target, you can remove those.
Keeping them is fine too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.