[Bug 597409] Review Request: php-channel-deepend - Survive The Deep End PEAR Channel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597409

Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Remi Collet <fedora at famillecollet.com> 2010-07-11 12:00:27 EDT ---
REVIEW
* no source files (channel.xml match latest upstream)
* package meets naming 
* package must meet packaging guidelines
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license (of the packages provided by the
channel).
* license is open source-compatible (BSD).
* BuildRequires are proper.
* %clean is present.
* package builds in mock (F-13).
* package installs properly
* channel (un)registered properly
* rpmlint (warnings are ok) :
$ rpmlint -v php-channel-deepend.spec
/home/extras/SRPMS/php-channel-deepend-1.3-1.fc13.src.rpm
/home/extras/RPMS/noarch/php-channel-deepend-1.3-1.fc13.noarch.rpm
php-channel-deepend.spec: I: checking-url
http://pear.survivethedeepend.com/channel.xml (timeout 10 seconds)
php-channel-deepend.src: I: checking
php-channel-deepend.src: I: checking-url http://www.survivethedeepend.com/
(timeout 10 seconds)
php-channel-deepend.src: I: checking-url
http://pear.survivethedeepend.com/channel.xml (timeout 10 seconds)
php-channel-deepend.noarch: I: checking
php-channel-deepend.noarch: I: checking-url http://www.survivethedeepend.com/
(timeout 10 seconds)
php-channel-deepend.noarch: W: no-documentation
2 packages and 1 specfiles checked; 0 errors, 1 warnings.
* final provides are sane:
php-channel(pear.survivethedeepend.com) = 1.3
php-channel-deepend = 1.3-1.fc13
+ final requires
/usr/bin/pear  
php-pear(PEAR)  
* %check is not present; no test suite provide.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear channel..)
* no documentation 
* %install start with rm
* %clean ok


Just a note, As I hate wilcards in %file, I will prefer
%{pear_xmldir}/%{name}.xml

*** APPROVED ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.