[Bug 613067] Review Request:spice - Implements the SPICE protocol

bugzilla at redhat.com bugzilla at redhat.com
Mon Jul 12 14:37:41 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=613067

Matthias Clasen <mclasen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #7 from Matthias Clasen <mclasen at redhat.com> 2010-07-12 10:37:39 EDT ---
Setting CFLAGS as you do now is probably a nop, looking at the definition of
%configure:

%configure \
  CFLAGS="${CFLAGS:-%optflags}" ; export CFLAGS ; \
  CXXFLAGS="${CXXFLAGS:-%optflags}" ; export CXXFLAGS ; \
...

but that is not a big deal. The rest looks fine now. Approved

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list