[Bug 576023] Review Request: libwebcam - user-space configuration of the uvcvideo driver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=576023

Hans de Goede <hdegoede at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841(FE-NEEDSPONSOR)      |

--- Comment #12 from Hans de Goede <hdegoede at redhat.com> 2010-07-13 04:58:47 EDT ---
Hi,

(In reply to comment #11)
> (In reply to comment #10)

<snip>

> > And I have matching patches for libwebcam / uvcdynctrl for this. I've send
> > these to libwebcam upstream, but unfortunately libwebcam upstream is not really
> > fast with processing these, so we will need to add these to the Fedora
> > libwebcam package for now.
> 
> Are these in the kernel already?
> 

The kernel parts of this are currently in Mauro (v4l-dvb maintainer) git
repository in his for_v2.6.36 branch, so it looks like they missed the 2.6.35
merge window. But I have commit access to Fedora's kernel so I'll likely add
them to Fedora's kernel packages once libwebcam is done.

> New spec: http://michael.cronenworth.com/RPMS/libwebcam.spec
> SRPM:
> http://michael.cronenworth.com/RPMS/libwebcam-0.2.0-0.3.20100322svn.fc13.src.rpm
> 

Thanks, hmm, I see you are still not including uvcdynctrl, see below...

> > 2) I would like to see some patches added to the Fedora package which add
> > support for menu and button controls, but lets first just tackle 1). If you can
> > provide an updated spec file and srpm with 1) fixed I'll do a more thorough
> > review of that.
> 
> I'll be more than happy to work with you on those patches.
> 

Good :)

<snip>

> > An other option is to show your skills by creating a couple of packages. Given
> > that your current libwebcam package only packages the library itself, I'm
> > guessing that you are packaging libwebcam because it is needed by something
> > else you plan to package. You could for example also submit that for review 

<snip>

> I am going to package uvcdynctrl plus my
> own app, uvcdynctrl-gtk (pretty obvious what that is). I wanted to start with
> libwebcam first, but if having those two packages in review as well will help
> this process along, I'll add them.

Yes having more apps in review will definitely help in getting sponsored as
that gives me a better idea of your packaging skills.

> I'll start with uvcdynctrl. My app needs a
> .desktop and icon file, which I have not made yet.
> 
> Bug 613857

Hmm, I guess I wasn't clear the first time, sorry. Given that uvcdynctrl and
libwebcam have the same upstream (note how the svn co command in both your spec
files is the same, iow both tarballs containt the same source) both should be
in a single package, or at least in a single srpm (you can build multiple rpms
from the same source rpm, like the -devel sub package).

I just checked and this is also how debian does it (generate both libwebcam and
uvcdynctrl packages from a single source tarbal / package) and I believe this
is the right thing to do.

They could be in separate packages if you want, although I don't see a reason
for that. My plan is to make libv4l Require the package which provides the udev
rules, so that the udev rules (and thus uvcdynctrl and thus libwebcam) always
get installed, making splitting them not really useful. But I have no real
preference (split or not split) either way.

The reason for making libv4l Require the udev rules is that there are plans to
add support for software autofocus (needed for example for the logitech pro
9000), and that in turn needs uvcdynctrl to enable the controls which control
the focus.

Can you please create 1 single spec file which builds both libwebcam and
uvcdynctrl, and then mark bug 613857 as a duplicate of this one?

Regards,

Hans

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.