[Bug 614008] Review Request: perl-File-FcntlLock - Perl module for file locking with fcntl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=614008

Mark Chappell <tremble at tremble.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tremble at tremble.org.uk
         AssignedTo|nobody at fedoraproject.org    |tremble at tremble.org.uk
               Flag|                            |fedora-review+

--- Comment #1 from Mark Chappell <tremble at tremble.org.uk> 2010-07-13 10:03:29 EDT ---
 - = N/A
 / = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [/] Package is named according to the Package Naming Guidelines.
 [/] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [/] Package meets the Packaging Guidelines including the Perl specific items
  [/] Versioned MODULE_COMPAT_ Requires
  [/] Non-Versioned CPAN URL tag
 [/] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: https://koji.fedoraproject.org/koji/taskinfo?taskID=2316397
 [/] Rpmlint output:
  perl-File-FcntlLock.src: W: spelling-error Summary(en_US) fcntl -> cantle,
scantly, fluently
  perl-File-FcntlLock.src: W: spelling-error %description -l en_US fcntl ->
cantle, scantly, fluently
  perl-File-FcntlLock.src: W: no-cleaning-of-buildroot %clean
  perl-File-FcntlLock.src: W: no-buildroot-tag
  perl-File-FcntlLock.src: W: no-%clean-section
  perl-File-FcntlLock.x86_64: W: spelling-error Summary(en_US) fcntl -> cantle,
scantly, fluently
  perl-File-FcntlLock.x86_64: W: spelling-error %description -l en_US fcntl ->
cantle, scantly, fluently
 [/] Package is not relocatable.
 [/] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [/] License field in the package spec file matches the actual license. 
     License type: GPL+ or Artistic (Standard Perl License)
 [/] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [/] Spec file is legible and written in American English.
 [/] Sources used to build the package matches the upstream source, as provided
in the spec URL.
    ee75374c6f1a9db2bca92d3a396f748e  File-FcntlLock-0.12.tar.gz
    ee75374c6f1a9db2bca92d3a396f748e  File-FcntlLock-0.12.tar.gz.1
 [/] Package is not known to require ExcludeArch
 [/] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [/] Package must own all directories that it creates.
 [/] Package requires other packages for directories it uses.
 [/] Package does not contain duplicates in %files.
 [/] Permissions on files are set properly.
 [/] Package consistently uses macros.
 [/] Package contains code, or permissible content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [/] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -static subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [/] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [/] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [/] Latest version is packaged.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [/] Reviewer should test that the package builds in mock.
     Tested on: https://koji.fedoraproject.org/koji/taskinfo?taskID=2316397
 [/] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: fedora-rawhide x86_64 and i686
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [/] %check is present and the tests pass
All tests successful.
Files=1, Tests=11,  2 wallclock secs ( 0.02 usr  0.00 sys +  0.03 cusr  0.00
csys =  0.05 CPU)
Result: PASS

=== COMMENTS ===

The rpmlint warnings are as I understand it out of date for F-13+ (missing
sections), or false positives (spelling)

package APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.