[Bug 605719] Review Request: mesa-demos - mesa opengl demos

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605719

Adam Jackson <ajax at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #4 from Adam Jackson <ajax at redhat.com> 2010-07-13 16:15:28 EDT ---
* rpmlint output on src rpm is mostly harmless:

mesa-demos.src: W: no-version-in-last-changelog
mesa-demos.src: W: strange-permission mesad-git-snapshot.sh 0755L
mesa-demos.src:1: W: macro-in-comment %define
mesa-demos.src:16: W: macro-in-comment %{tarball}
mesa-demos.src:16: W: macro-in-comment %{gitdate}
mesa-demos.src:41: W: macro-in-comment %setup
mesa-demos.src:41: W: macro-in-comment %{tarball}
mesa-demos.src:41: W: macro-in-comment %{gitdate}
glx-utils.x86_64: W: no-version-in-last-changelog
glx-utils.x86_64: W: no-manual-page-for-binary glxgears
glx-utils.x86_64: W: no-manual-page-for-binary glxinfo
mesa-demos.x86_64: W: no-version-in-last-changelog
mesa-demos.x86_64: W: no-documentation
mesa-demos-debuginfo.x86_64: W: no-version-in-last-changelog
3 packages and 0 specfiles checked; 0 errors, 6 warnings.

Please do attach a version number to the changelog before building into koji.

* Naming matches upstream, guidelines, and existing mesa-demos package.
* Spec file correctly named
* Meets Packaging Guidelines.  Most of mesa-demos is under %{_libdir}/mesa to
avoid conflicts with other packages, since there's a very large number of
demos.  This matches xscreensaver, for example.
! Meets Licensing Guidelines, in that MIT is fine, but does not include the
COPYING file in %doc.  Upstream doesn't appear to list one though.
* Builds in mock on x86_64.
* Owns the directory it creates.
* Does not install a desktop file, but should not; these are demo and debug
tools, not real applications.
* Does not install manual pages, but upstream does not provide any.

Package is approved.  Please work with upstream to include an appropriate
COPYING file in the source, but looks good otherwise.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.