[Bug 456353] Review Request: libffado - Free firewire audio driver library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456353

--- Comment #39 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com> 2010-07-13 23:32:26 EDT ---
(In reply to comment #38)
> Looks pretty good.  I see the following when running on libffado installed pkg
> (didn't know you could do that):
> 
> libffado.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libffado.so.2.999.0 /lib64/libexpat.so.1

ffado uses either expat or libxml++ for XML serialization. libxml++ is the
default, which I didn't change. Removing BR: expat-devel should clear the above
rpmlint.


> libffado.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libffado.so.2.999.0 /usr/lib64/libxml2.so.2
> libffado.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libffado.so.2.999.0 /lib64/libgobject-2.0.so.0
> libffado.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libffado.so.2.999.0 /usr/lib64/libsigc-2.0.so.0
> libffado.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libffado.so.2.999.0 /lib64/libglib-2.0.so.0

The above 4 are dragged in by
   $ pkg-config --libs libxml++-2.6
Not much I can do about them.

> libffado.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libffado.so.2.999.0 /usr/lib64/libavc1394.so.0
> 

As Stefan pointed out, libavc1394 is not really supported for the time being.
I'll get rid of the ENABLE_ALL for now. I imagine if it is not on by default,
there must be a reason.

> I guess this, and Jay's comment, are the last remaining items?    

Yeah, I have one more question. ffado wants to use the flags
-fomit-frame-pointer, -ffast-math, -funroll-loops for optimization. Will these
cause any harm? Is it okay if I add them to the build flags?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.