[Bug 612533] Review Request: qrencode - Generate QR 2D barcodes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=612533

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #10 from Parag AN(पराग) <panemade at gmail.com> 2010-07-14 01:03:28 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2316004
+ rpmlint is silent for SRPM and for RPM.
qrencode.src: W: spelling-error Summary(en_US) barcodes -> bar codes,
bar-codes, barcaroles
qrencode.x86_64: W: spelling-error Summary(en_US) barcodes -> bar codes,
bar-codes, barcaroles
qrencode-devel.x86_64: W: no-documentation
==> can be ignored.
+ source files match upstream url (sha1sum)
c3eb6c44553daa612a9bcf413d3cab7c46241373  qrencode-3.1.1.tar.gz
c3eb6c44553daa612a9bcf413d3cab7c46241373  qrencode-3.1.1.tar.gz.srpm
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ libqrencode.pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make check, tests are successfully run.
+ Package qrencode-3.1.1-4.fc14.x86_64  =>
Provides: libqrencode.so.3()(64bit)
Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit)
libpng12.so.0()(64bit) libpng12.so.0(PNG12_0)(64bit) libqrencode.so.3()(64bit) 
+ Package qrencode-devel-3.1.1-4.fc14.x86_64 =>
Provides: pkgconfig(libqrencode) = 3.1.1
Requires: /usr/bin/pkg-config libqrencode.so.3()(64bit)
+ Not a GUI application

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.