[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686

--- Comment #16 from Denis Arnaud <denis.arnaud_fedora at m4x.org> 2010-07-14 04:32:43 EDT ---
(In reply to comment #13)
> Buildroot is no longer needed:
> http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

You are right, and I did not remember that one. I've changed the BuildRoot tag
line by:
 %{?el5:BuildRoot: %(mktemp -ud
%{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)}
which is apparently the recommended option for EPEL 5 packaging
(http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag).

However, rpmlint reports a warning here:
 wsdlpull.src: W: no-buildroot-tag

But, as explained in that warning description, all is fine with a version of
rpm greater than 4.6. Which is of course the case for all the active Fedora
distributions and for EPEL 6 as well (but not for EPEL distributions for
version 5 downwards).


> You can save the "BuildRequires: dos2unix" by replacing the call to dos2unix by
> 
>     sed -i -e 's/\r$//'    

Yes, you are right. Even better, your solution sounds more Unix than that DOS
file converter...


The only thing remaining is to submit the patches upstream (to Vivek).


Thanks for your feedback.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.