[Bug 611873] Review Request: R-Rsolid - Quantile normalization and base calling for second generation sequencing data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=611873

Mattias Ellert <mattias.ellert at fysast.uu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mattias.ellert at fysast.uu.se
               Flag|                            |fedora-review?

--- Comment #1 from Mattias Ellert <mattias.ellert at fysast.uu.se> 2010-07-14 04:58:51 EDT ---
Fedora Review R-Rsolid 2010-07-14

rpmlint output:

R-Rsolid.x86_64: W: spelling-error Summary(en_US) Quantile -> Quintile,
Quartile, Quantize
R-Rsolid.x86_64: W: spelling-error %description -l en_US dinucleotide -> di
nucleotide, di-nucleotide, nucleotide
R-Rsolid.x86_64: W: spelling-error %description -l en_US quantile -> quintile,
quartile, quantize
R-Rsolid.x86_64: W: spelling-error %description -l en_US mis -> mus, mos, mid
R-Rsolid-devel.x86_64: W: only-non-binary-in-usr-lib
R-Rsolid-devel.x86_64: W: no-documentation
R-Rsolid.src: W: spelling-error Summary(en_US) Quantile -> Quintile, Quartile,
Quantize
R-Rsolid.src: W: spelling-error %description -l en_US dinucleotide -> di
nucleotide, di-nucleotide, nucleotide
R-Rsolid.src: W: spelling-error %description -l en_US quantile -> quintile,
quartile, quantize
R-Rsolid.src: W: spelling-error %description -l en_US mis -> mus, mos, mid
R-Rsolid.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 3)
4 packages and 0 specfiles checked; 0 errors, 11 warnings.

You should fix the "mixed-use-of-spaces-and-tabs" - the others looks
like noise.



+ Package named according to R packaging guidelines
+ Specfile named after package
+ Package license "Artistic 2.0" is a Fedora approved license

- I can not find any licensing information for this package, neither
  in the package source, nor on the upstream website. Could you please
  indicate your source for stating that this package is licensed under
  the "Artistic 2.0" license.

+ Specfile is written in legible English
+ Source matches upstream:

$ md5sum Rsolid_0.9-2.tar.gz srpm/Rsolid_0.9-2.tar.gz 
a86608e6c0599e3af9b8082c4e1d31bf  Rsolid_0.9-2.tar.gz
a86608e6c0599e3af9b8082c4e1d31bf  srpm/Rsolid_0.9-2.tar.gz

+ Package compiles

- BuildRequires tetex-latex is deprecated - tex(latex) should be used instead

- The package installs the /usr/lib64/R/library/Rsolid directory but
  does not own it

+ No duplicate files, and %files has %defattr
+ Specfile uses macros consistently
  (Though you could say --configure-args="--with-hdf5=%{_prefix}")

+ Package contains code
+ %doc is not runtime essential
+ Headers are in -devel
+ -devel depends on main with fully qualified version

- Package does not own others directories, but since it installs files
  in /usr/lib64/R/library it must have a Requires: R-core (see the
  template in the Fedora R packaging guidelines).

+ Installed files have valid UTF8 filenames.

- R modules packages no longer run scriptlets, so the Requires(post)
  and Requires(postun) should be removed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.