[Bug 611010] webkitgtk3 - GTK+ 3 port of webkit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=611010

--- Comment #8 from Ankur Sinha <sanjay.ankur at gmail.com> 2010-07-14 05:57:14 EDT ---
REVIEW: 

+ OK
- NA
? ISSUE

--------------------------------------------------------------------------------

+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
? License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
- Sources match upstream md5sum:
[Ankur at localhost rpmbuild]$ md5sum webkit-1.3.2.tar.gz
SOURCES/webkit-1.3.2.tar.gz 
8736b933d059288cdff9f9be64358954  webkit-1.3.2.tar.gz
8736b933d059288cdff9f9be64358954  SOURCES/webkit-1.3.2.tar.gz


- Package needs ExcludeArch
+ BuildRequires correct
+ Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
? Package has a correct %clean section.
+ Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ Package is code or permissible content.
 Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.

+ Headers/static libs in -devel subpackage.
+ Spec has needed ldconfig in post and postun
+ .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
+ -devel package Requires: %{name} = %{version}-%{release}
? .la files are removed.

- Package is a GUI app and has a .desktop file

- Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
+ No rpmlint output.
Ignorable warnings

- final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =;
rpm -qp --requires $i; echo; done
manually indented after checking each line.  I also remove the rpmlib junk and
anything provided by glibc.)

SHOULD Items:

? Should build in mock.
? Should build on all supported archs
- Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version
- check for outstanding bugs on package. (For core merge reviews)

Issues:

1. License would be AML (Apple MIT License) instead of MIT
https://fedoraproject.org/wiki/Licensing
https://fedoraproject.org/wiki/Licensing/Apple_MIT_License

2. clean section missing, assuming this is for F-13 + ?

3. global preferred to define

4. Would the WebCore/WebKit etc be better off as separate packages?

5. fails to build in mock. Build.log attached

6. rpmlint output:
[Ankur at localhost rpmbuild]$ rpmlint SPECS/webkitgtk3.spec
SRPMS/webkitgtk3-1.3.2-2.fc14.src.rpm 
SPECS/webkitgtk3.spec:106: W: macro-in-comment %patch1
SPECS/webkitgtk3.spec: W: no-cleaning-of-buildroot %install
SPECS/webkitgtk3.spec: W: no-cleaning-of-buildroot %clean
SPECS/webkitgtk3.spec: W: no-buildroot-tag
SPECS/webkitgtk3.spec: W: no-%clean-section
SPECS/webkitgtk3.spec:4: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab:
line 4)
SPECS/webkitgtk3.spec: W: invalid-url Source0:
http://www.webkitgtk.org/webkit-1.3.2.tar.gz HTTP Error 407: Proxy
Authentication Required
webkitgtk3.src: W: invalid-url URL: http://www.webkitgtk.org/ HTTP Error 407:
Proxy Authentication Required
webkitgtk3.src:106: W: macro-in-comment %patch1
webkitgtk3.src: W: no-cleaning-of-buildroot %install
webkitgtk3.src: W: no-cleaning-of-buildroot %clean
webkitgtk3.src: W: no-buildroot-tag
webkitgtk3.src: W: no-%clean-section
webkitgtk3.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 4)
webkitgtk3.src: W: invalid-url Source0:
http://www.webkitgtk.org/webkit-1.3.2.tar.gz <urlopen error timed out>
1 packages and 1 specfiles checked; 0 errors, 15 warnings.

7. haven't been able to check for la files yet.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.