[Bug 614181] Review Request: libguess - High-speed character set detection library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=614181

Mattias Ellert <mattias.ellert at fysast.uu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mattias.ellert at fysast.uu.se

--- Comment #1 from Mattias Ellert <mattias.ellert at fysast.uu.se> 2010-07-14 07:33:12 EDT ---
Fedora Review libguess 2010-07-14

rpmlint output:

libguess.x86_64: W: spelling-error %description -l en_US automata -> automats,
automat, automate
libguess.x86_64: W: spelling-error %description -l en_US reentrant -> re
entrant, re-entrant, reentrance
libguess-devel.x86_64: W: no-documentation
libguess.src: W: spelling-error %description -l en_US automata -> automats,
automat, automate
libguess.src: W: spelling-error %description -l en_US reentrant -> re entrant,
re-entrant, reentrance
libguess.src: W: no-buildroot-tag
libguess.src: W: invalid-url Source0: libguess-mercurial-20100713.tar.bz2
4 packages and 0 specfiles checked; 0 errors, 7 warnings.

No issues needs fixing


+ Package named according to guidelines
+ Specfile named after package
+ The package license tag (BSD) is a Fedora approved license
+ The package license tag matches the license in the sources
+ The license file (COPYING) is included as %doc
+ Specfile is written in legible English

- The information in the specfile is insufficient to recreate the source
  archive - not possible to validate. Please add as comment the sequence
  of commands needed to create the source. See
  https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control

+ Package builds - koji scratch build:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=2318441
+ BuildRequires are sane
+ no locales
+ Package calls ldconfig appropriately
+ no bundled libraries
+ Package own directories it creates

The package relies on the autogenerated requires on /usr/bin/pkg-config
for the ownership of /usr/lib64/pkgconfig - if this package will be built
for EPEL a dependency on pkg-config needs to be added

+ No duplicate files
+ Permissions are sane and %files has %defattr
+ Specfile use macros consistently
+ Package contains code
+ %doc is not runtime essential
+ Header files in -devel
+ No static libraries
+ .so symlink in -devel
+ -devel requires main with fully qualified version
+ No .la files
+ Package does not own other's directories
+ Installed files have valid UTF8 filenames


Summary: OK except for the lacking description for recreating the source

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.