[Bug 226355] Merge Review: rarpd

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226355

--- Comment #1 from Jiri Popelka <jpopelka at redhat.com> 2010-07-14 12:43:42 EDT ---
NO source files match upstream.
- The source URL is not accessible.
  I think Debian's ftp can be used instead
  http://ftp.debian.org/debian/pool/main/r/rarpd/

YES package meets naming and versioning guidelines.
YES specfile is properly named, is cleanly written and uses macros
consistently.
YES dist tag is present.
YES build root is correct.
YES license field matches the actual license.
YES license is open source-compatible.

NO License text included in package.

YES latest version is being packaged.
YES BuildRequires are proper.
YES compiler flags are appropriate.
YES %clean is present.
YES package builds in mock (Rawhide/x86_64).
YES debuginfo package looks complete.

NO rpmlint is silent.
 rarpd.x86_64: W: no-url-tag
 rarpd.x86_64: W: conffile-without-noreplace-flag /etc/rc.d/init.d/rarpd
 rarpd.x86_64: E: executable-marked-as-config-file /etc/rc.d/init.d/rarpd
 - do not mark initscript with %config
 - use %{_initddir} instead of /etc/rc.d/init.d

NO final provides and requires look sane.
 - Prereq should be replaced with Requires

N/A %check is present and all tests pass.
YES no shared libraries are added to the regular linker search paths.
YES owns the directories it creates.
YES doesn't own any directories it shouldn't.
YES no duplicates in %files.
YES file permissions are appropriate.
YES no scriptlets present.
YES code, not content.
YES documentation is small, so no -docs subpackage is necessary.
YES %docs are not necessary for the proper functioning of the package.
YES no headers.
YES no pkgconfig files.
YES no libtool .la droppings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.