[Bug 614548] Review Request: qt-mobility - Qt Mobility Framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=614548

Adam Miller <maxamillion at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #5 from Adam Miller <maxamillion at fedoraproject.org> 2010-07-14 16:28:39 EDT ---
YES - Package meets naming and packaging guidelines
YES - Spec file matches base package name.
YES - Spec has consistant macro usage.
YES - Meets Packaging Guidelines.
YES - License
YES - License field in spec matches
YES - License file included in package
YES - Spec in American English
YES - Spec is legible.
YES - Sources match upstream md5sum:

NA - Package needs ExcludeArch
YES - BuildRequires correct
YES - Spec handles locales/find_lang
NA - Package is relocatable and has a reason to be.
YES - Package has %defattr and permissions on files is good.
YES - Package has a correct %clean section.
YES - Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
YES - Package is code or permissible content.
YES - Doc subpackage needed/used.
YES - Packages %doc files don't affect runtime.

YES - Headers/static libs in -devel subpackage.
NA - Spec has needed ldconfig in post and postun
NA - .pc files in -devel subpackage/requires pkgconfig
YES- .so files in -devel subpackage.
YES - -devel package Requires: %{name} = %{version}-%{release}
NA - .la files are removed.

NA - Package is a GUI app and has a .desktop file

YES - Package compiles and builds on at least one arch.
YES - Package has no duplicate files in %files.
YES - Package doesn't own any directories other packages own.
YES - Package owns all the directories it creates.
NO - No rpmlint output.
YES - final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =;
rpm -qp --requires $i; echo; done
manually indented after checking each line.  I also remove the rpmlib junk and
anything provided by glibc.)

SHOULD Items:

YES - Should build in mock.
YES - Should build on all supported archs
YES - Should function as described.
NA - Should have sane scriptlets.
NO - Should have subpackages require base package with fully versioned depend.
YES - Should have dist tag
YES - Should package latest version
NA - check for outstanding bugs on package. (For core merge reviews)

Issues:
1. NONE


------

Rex, sorry about the -devel requires main. Completely overlooked, apologies.

------

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.