[Bug 614196] Review Request: gccxml - XML output extension to GCC

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=614196

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |martin.gieseking at uos.de
               Flag|                            |fedora-review+

--- Comment #4 from Martin Gieseking <martin.gieseking at uos.de> 2010-07-15 03:27:51 EDT ---
Here's the formal review. The package looks fine and works as expected.
Since some header files refer to a file containing the GCC Runtime Library
Exception, I suggest to ask upstream to add this file together with a copy of
the GPLv3 license text which is also missing.

$ rpmlint gccxml-*.rpm|fgrep -v devel-file
gccxml.src: W: invalid-url Source0: gccxml-0.9.0-20100713.tar.gz
gccxml.x86_64: W: no-manual-page-for-binary gccxml_cc1plus
3 packages and 0 specfiles checked; 0 errors, 59 warnings.

All remaining warnings are expected and can be ignored.

---------------------------------
Key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: File containing the text of the license(s) for the package must be
included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
    $ for f in gccxml-0.9.0-20100713.tar.gz*; do tar xzOf $f|md5sum --binary;
done
    1a7b0a033d3fe06fd5425962fd83e646  -
    1a7b0a033d3fe06fd5425962fd83e646  -

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
    koji scratch builds:
    F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2321215
    F-14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2321302 

[.] MUST: If the package does not successfully compile, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly. 
    - locales in GCC/libcpp/po are not installed by gccxml

[.] MUST: Ppackages which store shared libraries must call ldconfig in %post
and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: Files must not be listed more than once in the spec file's %files
listings.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[.] MUST: Header files must be in a -devel package.
    - packaged header files are part of the compiler and thus must be part of
the base package

[+] MUST: Static libraries must be in a -static package.
[.] MUST: Library files without a numeric suffix must go in a -devel package.
[.] MUST: devel packages must require the base package 
[+] MUST: Packages must NOT contain any .la libtool archives, ...
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.


[X] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
    - files containing the text of GPLv3 and the GCC Runtime Library Exception
should be added upstream.

[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...

----------------
Package APPROVED
----------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.