[Bug 510651] Review Request: trafshow - A tool for real-time network traffic visualization
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jul 15 10:47:19 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=510651
manuel wolfshant <wolfy at nobugconsulting.ro> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |wolfy at nobugconsulting.ro
Flag| |fedora-review?
--- Comment #10 from manuel wolfshant <wolfy at nobugconsulting.ro> 2010-07-15 06:47:15 EDT ---
It's nice that you have thought on installing an AUTHORS file, but first of all
it must exist :).
Package Review
==============
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines.
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: devel/x86_64, EL-6/x86_64
[x] Rpmlint output:
source RPM:
trafshow.src: I: enchant-dictionary-not-found ru
trafshow.src: W: unexpanded-macro %description -l C %description
trafshow.src: W: spelling-error %description -l en_US boolean -> Boolean, boo
lean, boo-lean
trafshow.src: W: spelling-error %description -l en_US ru -> roe, Ru, r
trafshow.src: W: spelling-error %description -l en_US продолжительно
trafshow.src: W: spelling-error %description -l en_US отображает
trafshow.src: W: spelling-error %description -l en_US информацию
trafshow.src: W: spelling-error %description -l en_US о
trafshow.src: W: spelling-error %description -l en_US сетевом
trafshow.src: W: spelling-error %description -l en_US трафике
trafshow.src: W: spelling-error %description -l en_US на
trafshow.src: W: spelling-error %description -l en_US выбранном
trafshow.src: W: spelling-error %description -l en_US интерфейсе
trafshow.src: W: spelling-error %description -l en_US в
trafshow.src: W: spelling-error %description -l en_US соответствии
trafshow.src: W: spelling-error %description -l en_US с
trafshow.src: W: spelling-error %description -l en_US булевым
trafshow.src: W: spelling-error %description -l en_US выражением
trafshow.src: W: spelling-error %description -l en_US Программа
trafshow.src: W: spelling-error %description -l en_US периодически
trafshow.src: W: spelling-error %description -l en_US сортирует
trafshow.src: W: spelling-error %description -l en_US и
trafshow.src: W: spelling-error %description -l en_US обновляет
trafshow.src: W: spelling-error %description -l en_US эту
trafshow.src: W: spelling-error %description -l en_US может
trafshow.src: W: spelling-error %description -l en_US быть
trafshow.src: W: spelling-error %description -l en_US очень
trafshow.src: W: spelling-error %description -l en_US полезна
trafshow.src: W: spelling-error %description -l en_US для
trafshow.src: W: spelling-error %description -l en_US распознавания
trafshow.src: W: spelling-error %description -l en_US паразитного
trafshow.src: W: spelling-error %description -l en_US сетевого
trafshow.src: W: spelling-error %description -l en_US трафика
trafshow.src: W: spelling-error %description -l en_US или
trafshow.src: W: spelling-error %description -l en_US оценки
trafshow.src: W: spelling-error %description -l en_US текущей
trafshow.src: W: spelling-error %description -l en_US утилизации
trafshow.src: W: spelling-error %description -l en_US интерфейса
trafshow.src: W: unexpanded-macro %description -l ru %description
1 packages and 0 specfiles checked; 0 errors, 38 warnings.
=> All are ignorable.
binary RPM:
trafshow.x86_64: I: enchant-dictionary-not-found ru
trafshow.x86_64: W: unexpanded-macro %description -l C %description
trafshow.x86_64: W: spelling-error %description -l en_US boolean -> Boolean,
boo lean, boo-lean
trafshow.x86_64: W: spelling-error %description -l en_US ru -> roe, Ru, r
trafshow.x86_64: W: spelling-error %description -l en_US продолжительно
trafshow.x86_64: W: spelling-error %description -l en_US отображает
trafshow.x86_64: W: spelling-error %description -l en_US информацию
trafshow.x86_64: W: spelling-error %description -l en_US о
trafshow.x86_64: W: spelling-error %description -l en_US сетевом
trafshow.x86_64: W: spelling-error %description -l en_US трафике
trafshow.x86_64: W: spelling-error %description -l en_US на
trafshow.x86_64: W: spelling-error %description -l en_US выбранном
trafshow.x86_64: W: spelling-error %description -l en_US интерфейсе
trafshow.x86_64: W: spelling-error %description -l en_US в
trafshow.x86_64: W: spelling-error %description -l en_US соответствии
trafshow.x86_64: W: spelling-error %description -l en_US с
trafshow.x86_64: W: spelling-error %description -l en_US булевым
trafshow.x86_64: W: spelling-error %description -l en_US выражением
trafshow.x86_64: W: spelling-error %description -l en_US Программа
trafshow.x86_64: W: spelling-error %description -l en_US периодически
trafshow.x86_64: W: spelling-error %description -l en_US сортирует
trafshow.x86_64: W: spelling-error %description -l en_US и
trafshow.x86_64: W: spelling-error %description -l en_US обновляет
trafshow.x86_64: W: spelling-error %description -l en_US эту
trafshow.x86_64: W: spelling-error %description -l en_US может
trafshow.x86_64: W: spelling-error %description -l en_US быть
trafshow.x86_64: W: spelling-error %description -l en_US очень
trafshow.x86_64: W: spelling-error %description -l en_US полезна
trafshow.x86_64: W: spelling-error %description -l en_US для
trafshow.x86_64: W: spelling-error %description -l en_US распознавания
trafshow.x86_64: W: spelling-error %description -l en_US паразитного
trafshow.x86_64: W: spelling-error %description -l en_US сетевого
trafshow.x86_64: W: spelling-error %description -l en_US трафика
trafshow.x86_64: W: spelling-error %description -l en_US или
trafshow.x86_64: W: spelling-error %description -l en_US оценки
trafshow.x86_64: W: spelling-error %description -l en_US текущей
trafshow.x86_64: W: spelling-error %description -l en_US утилизации
trafshow.x86_64: W: spelling-error %description -l en_US интерфейса
trafshow.x86_64: W: unexpanded-macro %description -l ru %description
1 packages and 0 specfiles checked; 0 errors, 38 warnings.
=> as above, all ignorable
[x] Package is not relocatable.
[x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type:BSD
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package match the upstream source, as provided
in the spec URL.
SHA1SUM of source file: 1c68f603f12357e932c83de850366c9b46e53d89
trafshow-5.2.3.tgz
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf %{buildroot}.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Final provides and requires are sane.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[x] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: devel/x86_64, EL-6beta2/x86_64
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on: devel/x86_64, EL-6beta2/x86_64
[x] Package functions as described.
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
[-] %check is present and the test passes.
=== Issues ===
1. The AUTHORS file referenced in %files does not exist
=== Final Notes ===
1. You should either a) add the AUTHORS file to the source tarball and create
something like trafshow-5.2.3.1.tgz or b) add the AUTHORS file as SOURCE1 or c)
remove AUTHORS from %files.
I suggest to use the option b) from above.
I'll approve your package once you fix the above issue.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list