[Bug 612174] Review Request: eurephia - An advanced and flexible OpenVPN user authentication plug-in

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=612174

Mattias Ellert <mattias.ellert at fysast.uu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #4 from Mattias Ellert <mattias.ellert at fysast.uu.se> 2010-07-15 09:13:11 EDT ---
Fedora Review eurephia 2010-07-15

rpmlint output:

$ rpmlint eurephia-1.0.0-4.fc12.src.rpm eurephia-*1.0.0-4.fc12.x86_64.rpm 
eurephia.src: W: spelling-error %description -l en_US iptables -> potables,
portables, birdtables
eurephia.src:91: W: configure-without-libdir-spec
eurephia.x86_64: W: spelling-error %description -l en_US iptables -> potables,
portables, birdtables
eurephia-utils.x86_64: W: spelling-error %description -l en_US saltdecode ->
salt decode, salt-decode, saltigrade
8 packages and 0 specfiles checked; 0 errors, 4 warnings.

(no fixes needed for those)


+ Package is named according to guidelines
+ Specfile is named after the package
+ Package license tag (GPLv2) is a Fedora approved license
+ The stated license matches the license statements in the sources
+ The license file (LICENSE.txt) is included as %doc
+ Specfile written in legible English
+ Source matches upstream:

$ md5sum eurephia-1.0.0.tar.bz2 srpm/eurephia-1.0.0.tar.bz2 
395040dd170e156a8f0e6d3150e0ea1e  eurephia-1.0.0.tar.bz2
395040dd170e156a8f0e6d3150e0ea1e  srpm/eurephia-1.0.0.tar.bz2

+ Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2321726
+ BuildRequires are sane
+ No locales
+ No libraries in default library path
+ No bundled libraries

- Orphaned directories not owned by any package:
  /usr/lib64/eurephia
  /usr/share/eurephia
  /usr/share/eurephia/xslt

+ No duplicate files
+ Permissions are sane and %files have %defattr

+ Specfile uses macros consistently (though the %{name} macro could be
  used more often

+ Contains code
+ %doc is not runtime essential
+ No header files
+ No static libraries

- Intra-package dependencies do not use fully qualified versions

+ No libtool archives
+ Package does not own other's directories
+ Installed files have valid UTF8 filenames

(unbalanced parentheses in the last changelog entry)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.