[Bug 612174] Review Request: eurephia - An advanced and flexible OpenVPN user authentication plug-in

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=612174

--- Comment #12 from David Sommerseth <davids at redhat.com> 2010-07-15 12:17:58 EDT ---
Spec URL: http://people.redhat.com/dsommers/eurephia/eurephia.spec
SRPM URL:
http://people.redhat.com/dsommers/eurephia/eurephia-1.0.0-8.fc12.src.rpm

Thank you for your patience!  I hope I got it right this time.

(In reply to comment #10)
> (In reply to comment #9)
> > The %{_libdir}/eurephia directory should be in the eurephia-sqlite3 package and
> > not in the main eurephia package, since eurephia depends on eurephia-sqlite3
> > but not the other way.
> 
> This is still not resolved. You can still install only the eurephia-sqlite3
> package - in which case nothing owns %{_libdir}/eurephia.

Gee ... is it possible!  Sorry about that, my eyes slipped on this one.

> > More database drivers will come in the future and  they will all go into
> > %{_libdir}/eurephia.  A web-based admin utility is being planned, which will
> > use %{_datadir}/eurephia/ as well.  So that's the reason for my way of
> > thinking.
> > 
> > But when not looking into the future now, I do agree to your comments.    
> 
> It is of course possible to keep the directory in the main package, but then
> you need to add requires on the main package to packages that install in the
> directory.

Yeah, as this is under development, I'll spend some time thinking about it to
get the dependencies right.  The dependencies between -admin and -sqlite3
package will also go away in the future.  So I don't think it makes sense to
solve this right now.  It depends on which features the first next release will
get.

> You have a typo (two equals) here:
> 
> Requires: eurephia-sqlite3 = = %{version}-%{release}    

Ouch!  Fixed!


Regarding not using %{?_smp_mflags}.  That is intentional.  I have seen a few
builds fail when doing parallel build.  So I wanted to avoid this for now, to
figure out why it fails.  The project is quite small, so the benefit of
parallel building is minimal right now.  But it's on my radar to fix this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.