[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy

bugzilla at redhat.com bugzilla at redhat.com
Fri Jul 16 08:40:15 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506425

--- Comment #8 from manuel wolfshant <wolfy at nobugconsulting.ro> 2010-07-16 04:40:14 EDT ---
Aleksey, please increase the release tag each time you modify the spec file.
Mind that in the new spec you have introduced a typo, under %description
("Litle" should be "Little").

Why did you decide to go back to dos2unix instead of using sed for the files
below /doc ? It is not incorrect, but not needed, the previous version, using
sed was OK.

Why did you give up in creating the lightsquid-apache subpackage ?  Instead of
moving the scripts to the subpackage, you have moved the apache config file to
the main package. You can see at
http://koji.fedoraproject.org/koji/getfile?taskID=2323573&name=lightsquid-1.8-2.fc14.noarch.rpm
what I am talking about.

Since you have decided to create a system _group_ named lightsquid, the cron
entry which is supposed to run as _user_ lightsquid is now incorrect. OTOH
could you please explained the rationale for this new group ? I do not see it
being used anywhere in the spec.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list