[Bug 611873] Review Request: R-Rsolid - Quantile normalization and base calling for second generation sequencing data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=611873

--- Comment #5 from Mattias Ellert <mattias.ellert at fysast.uu.se> 2010-07-16 11:12:36 EDT ---
New rpmlint output:

R-Rsolid.src: W: spelling-error Summary(en_US) Quantile -> Quintile, Quartile,
Quantize
R-Rsolid.src: W: spelling-error %description -l en_US dinucleotide -> di
nucleotide, di-nucleotide, nucleotide
R-Rsolid.src: W: spelling-error %description -l en_US quantile -> quintile,
quartile, quantize
R-Rsolid.src: W: spelling-error %description -l en_US mis -> mus, mos, mid
R-Rsolid.x86_64: W: spelling-error Summary(en_US) Quantile -> Quintile,
Quartile, Quantize
R-Rsolid.x86_64: W: spelling-error %description -l en_US dinucleotide -> di
nucleotide, di-nucleotide, nucleotide
R-Rsolid.x86_64: W: spelling-error %description -l en_US quantile -> quintile,
quartile, quantize
R-Rsolid.x86_64: W: spelling-error %description -l en_US mis -> mus, mos, mid
R-Rsolid-devel.x86_64: W: only-non-binary-in-usr-lib
R-Rsolid-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 10 warnings.

Same as before except that the "mixed-use-of-spaces-and-tabs" is no longer
there. The remaining warnings can be ignored. (The "only-non-binary-in-usr-lib"
is not new - it was there before too.)


+ New source states the license in the DESCRIPTION file
+ New source matches upstream:

$ md5sum srpm/Rsolid_0.9-2.tar.gz Rsolid_0.9-2.tar.gz 
4a619392ad87865bc4f4c1588199f75a  srpm/Rsolid_0.9-2.tar.gz
4a619392ad87865bc4f4c1588199f75a  Rsolid_0.9-2.tar.gz

+ BuildRequires are now good
+ Package now owns directories it creates

- New specfile lists some files more than once. Warnings during rpmbuild:

warning: File listed twice: /usr/lib64/R/library/Rsolid/DESCRIPTION
warning: File listed twice: /usr/lib64/R/library/Rsolid/html
warning: File listed twice: /usr/lib64/R/library/Rsolid/html/00Index.html
warning: File listed twice: /usr/lib64/R/library/Rsolid/html/Rsolid.html

This is a better %files section:

%files
%defattr(-, root, root, -)
%dir %{_libdir}/R/library/%{packname}
%doc %{_libdir}/R/library/%{packname}/DESCRIPTION
%doc %{_libdir}/R/library/%{packname}/html
%{_libdir}/R/library/%{packname}/INDEX
%{_libdir}/R/library/%{packname}/Meta
%{_libdir}/R/library/%{packname}/R
%{_libdir}/R/library/%{packname}/data
%{_libdir}/R/library/%{packname}/help
%{_libdir}/R/library/%{packname}/libs

+ Package now properly depend on packages owning directories where files are
  installed
+ The relic Requires for the no longer existing scriptlets have been removed

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.