[Bug 613525] Review Request: klog - KLog is a Ham radio logging program for KDE

bugzilla at redhat.com bugzilla at redhat.com
Fri Jul 16 15:44:33 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=613525

manuel wolfshant <wolfy at nobugconsulting.ro> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
               Flag|                            |fedora-review?

--- Comment #2 from manuel wolfshant <wolfy at nobugconsulting.ro> 2010-07-16 11:44:32 EDT ---
Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: devel/x86_64
 [x] Rpmlint output:
source RPM:
klog.src: W: spelling-error %description -l en_US Cabrillo -> Carrillo,
Cabriolet, Carillon
klog.src: W: spelling-error %description -l en_US Galician -> Galilean,
Gallicism, Alicia
binary RPM:
klog.x86_64: W: spelling-error %description -l en_US Cabrillo -> Carrillo,
Cabriolet, Carillon
klog.x86_64: W: spelling-error %description -l en_US Galician -> Galilean,
Gallicism, Alicia
=> all ignorable
 [x] Package is not relocatable.
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type:GPLv2+
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package match the upstream source, as provided
in the spec URL.
     SHA1SUM of source file: dfee05ec729c9a92408ade41618728adb4adb193 
klog-0.5.6.tar.gz
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [x] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [!] Package must own all directories that it creates.
=> See issue 1
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [!] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
=> See issue 2
 [x] Package does not own files or directories owned by other packages.
 [x] Final provides and requires are sane.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [x] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: koji scratch build
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: koji scratch build
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [-] %check is present and the test passes.

=== OPTIONAL ITEMS ===
 [x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Package has a %clean section, which contains rm -rf or $RPM_BUILD_ROOT.

=== Issues ===
1. The following files are included
-rw-r--r--    1 root    root                     5275 Jul  4 21:47
/etc/skel/.klog/awa/tpea.awa
-rw-r--r--    1 root    root                     5368 Jul  4 21:47
/etc/skel/.klog/awa/was.awa
-rw-r--r--    1 root    root                    54267 Jul  4 21:47
/etc/skel/.klog/data/cty.dat
-rw-r--r--    1 root    root                      324 Jul  4 21:47
/etc/skel/.klog/data/klog-contest-cabrillo-formats.txt
but the directories /etc/skel/.klog and below are not owned.
2. desktop-file-install should be used to install (and verify) the desktop file
or at least desktop-file-validate should be used to validate the one installed
by the application's installer


=== Final Notes ===
 Please fix the issues noted above and we are good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list