[Bug 576023] Review Request: libwebcam - user-space configuration of the uvcvideo driver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=576023

--- Comment #17 from Hans de Goede <hdegoede at redhat.com> 2010-07-17 05:04:28 EDT ---
Looks good, full review below:

Good:
- rpmlint checks return:
libwebcam.x86_64: W: spelling-error Summary(en_US) uvcvideo -> videodisc,
videotex, videotape
libwebcam.x86_64: W: spelling-error %description -l en_US uvcvideo ->
videodisc, videotex, videotape
libwebcam.x86_64: W: spelling-error %description -l en_US webcams -> web cams,
web-cams, webmaster
libwebcam-devel.x86_64: W: no-documentation
uvcdynctrl.x86_64: W: spelling-error Summary(en_US) libwebcam -> liberalism,
Liberace
uvcdynctrl.x86_64: W: spelling-error %description -l en_US webcams -> web cams,
web-cams, webmaster
uvcdynctrl.x86_64: W: spelling-error %description -l en_US libwebcam ->
liberalism, Liberace
uvcdynctrl.x86_64: W: spelling-error %description -l en_US webcam -> web cam,
web-cam, webmaster
libwebcam.src: W: spelling-error Summary(en_US) uvcvideo -> videodisc,
videotex, videotape
libwebcam.src: W: spelling-error %description -l en_US uvcvideo -> videodisc,
videotex, videotape
libwebcam.src: W: spelling-error %description -l en_US webcams -> web cams,
web-cams, webmaster
libwebcam.src: W: no-buildroot-tag
libwebcam.src: W: invalid-url Source0: libwebcam-0.2.0.tar.xz
6 packages and 0 specfiles checked; 0 errors, 13 warnings.
(these can all be ignored)
- package meets naming guidelines
- package meets packaging guidelines
- license (LGPLv3+ and GPLv3+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r

Needs work:
-missing BuildRequires gengetopt
-%{_datadir}/uvcdynctrl and %{_datadir}/uvcdynctrl/data directories are unowned
 instead of:
 %dir %{_datadir}/uvcdynctrl/data/046d
 %{_datadir}/uvcdynctrl/data/046d/logitech.xml
 you can wrirte just:
 %{_datadir}/uvcdynctrl
 And then rpm will include all dirs and files under %{_datadir}/uvcdynctrl
-the udev rules do not work when the camera is already plugged in when the
 system starts up. The problem is that the /lib/udev/uvcdynctrl script tries
 to write to /var/log when / is still mounted ro. I've fixed this locally
 by changing the logfile to /dev/.udev/uvcdynctrl-udev.log

I like the packaging work I've seen from you so far, so if you fix these
remaining need work items, then I'll approve this package and sponser you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.