[Bug 226094] Merge Review: libXxf86dga

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226094

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |ajax at redhat.com,
                   |                            |peter.hutterer at redhat.com,
                   |                            |tomspur at fedoraproject.org
         AssignedTo|nobody at fedoraproject.org    |tomspur at fedoraproject.org
               Flag|                            |fedora-review?

--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org> 2010-07-18 19:30:51 EDT ---
Review:
(CC'ing the people, who modified this recently.)

Good:
- name ok
- BR ok (pkgconfig is unneeded, but that doesn't matter here)
- %prep ok
- rpmlint:
libXxf86dga.src: W: invalid-url Source0:
ftp://ftp.x.org/pub/individual/lib/libXxf86dga-1.1.1.tar.bz2 <urlopen error ftp
error: timed out>
libXxf86dga.x86_64: W: spelling-error Summary(en_US) runtime -> run time,
run-time, runtish
- %files ok
- license ok
- latest version packaged
- libs correctly packaged
- no locale files
- no *.la


Needswork:
- https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
- please use INSTALL="install -p", when installing
- libXxf86dga.x86_64: W: name-repeated-in-summary C libXxf86dga
  A slightly bigger description wouldn't hurt.
- libXxf86dga.src:51: W: macro-in-comment %doc -> should be %%doc
- %doc: There is also a README

___________________________________________________________________________


Not much to do, but not approving this now, because this is a merge review and
not a normal package review...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.