[Bug 615575] Review Request: perl-Parse-Method-Signatures - Perl6 like method signature parser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=615575

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-07-19 02:57:04 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2325443
+ rpmlint output for SRPM and for RPM.
perl-Parse-Method-Signatures.src: W: no-cleaning-of-buildroot %clean
perl-Parse-Method-Signatures.src: W: no-buildroot-tag
perl-Parse-Method-Signatures.src: W: no-%clean-section
==> this is due to new guidelines. 
+ source files match upstream url (sha1sum)
1df162eca8fd1b99497f7677b714116ebfb8305c 
Parse-Method-Signatures-1.003013.tar.gz
1df162eca8fd1b99497f7677b714116ebfb8305c 
Parse-Method-Signatures-1.003013.tar.gz.srpm

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present which is not needed now.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=344,  2 wallclock secs ( 0.07 usr  0.00 sys +  2.32 cusr  0.08
csys =  2.47 CPU)

+ Package  perl-Parse-Method-Signatures-1.003013-1.fc14.noarch =>
Provides: perl(Parse::Method::Signatures) = 1.003013
perl(Parse::Method::Signatures::Param)
perl(Parse::Method::Signatures::Param::Bindable)
perl(Parse::Method::Signatures::ParamCollection)
perl(Parse::Method::Signatures::Param::Named)
perl(Parse::Method::Signatures::Param::Placeholder)
perl(Parse::Method::Signatures::Param::Positional)
perl(Parse::Method::Signatures::Param::Unpacked)
perl(Parse::Method::Signatures::Param::Unpacked::Array)
perl(Parse::Method::Signatures::Param::Unpacked::Hash)
perl(Parse::Method::Signatures::Sig)
perl(Parse::Method::Signatures::TypeConstraint)
perl(Parse::Method::Signatures::Types)

Requires: perl(base) perl(Carp) perl(List::MoreUtils) perl(Moose)
perl(Moose::Role) perl(Moose::Util::TypeConstraints) perl(MooseX::Types)
perl(MooseX::Types::Moose) perl(MooseX::Types::Structured)
perl(MooseX::Types::Util) perl(namespace::clean)
perl(Parse::Method::Signatures::ParamCollection)
perl(Parse::Method::Signatures::Types) perl(PPI) perl(strict) perl(warnings)
rpmlib(VersionedDependencies) <= 3.0.3-1

+ Not a GUI application

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.