[Bug 226094] Merge Review: libXxf86dga

bugzilla at redhat.com bugzilla at redhat.com
Mon Jul 19 09:51:51 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226094

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Thomas Spura <tomspur at fedoraproject.org> 2010-07-19 05:51:50 EDT ---
(In reply to comment #2)
> (In reply to comment #1)
> > Needswork:
> > - https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
> done
> > - please use INSTALL="install -p", when installing
> done
> 
> > - libXxf86dga.x86_64: W: name-repeated-in-summary C libXxf86dga
> >   A slightly bigger description wouldn't hurt.
> 
> no, people may be tempted to use it then ;)

Heh, that's to risky.^^

> > - libXxf86dga.src:51: W: macro-in-comment %doc -> should be %%doc
> removed
> 
> > - %doc: There is also a README
> 
> added.

Thanks.

> > Not much to do, but not approving this now, because this is a merge review and
> > not a normal package review...    
> 
> out of interest: the package has been around for ages, what would the formal
> approval really do?    

The packages needing merge reviews used to be in Fedora Core and did not get
any review yet. This makes sure, that they don't violate the guidelines (e.g.
have a correct license and so on).
In this case it was more a cosmetic issue, but e.g. the python guidelines
changed quite a lot, so python packages in the merge review queue will need
more changes.
(That's the reason, why I started with xorg-x11-* ones ;-))

Also see (Don't know, why that's a draft...):
https://fedoraproject.org/wiki/Merge_Reviews
http://lists.fedoraproject.org/pipermail/devel/2010-July/138566.html

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the package-review mailing list