[Bug 615847] Review Request: oflb-asana-math-fonts - An OpenType font with a MATH table

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=615847

Ankur Sinha <sanjay.ankur at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Ankur Sinha <sanjay.ankur at gmail.com> 2010-07-19 06:20:22 EDT ---
REVIEW:

+ OK
? ISSUE
- NA

+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
- Sources match upstream md5sum:

- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
? Package has a correct %clean section.
? Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ Package is code or permissible content.
- Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

- Package is a GUI app and has a .desktop file

+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
? No rpmlint output.

SHOULD Items:

+ Should build in mock.
- Should build on all supported archs
- Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
- Should package latest version
- check for outstanding bugs on package. (For core merge reviews)

Issues:

1. rpmlint output:
[Ankur at localhost SPECS]$ rpmlint oflb-asana-math-fonts.spec
../SRPMS/oflb-asana-math-fonts-0.914-8.fc13.src.rpm
/var/lib/mock/fedora-rawhide-i386/result/*.rpm
oflb-asana-math-fonts.spec: W: no-cleaning-of-buildroot %install
oflb-asana-math-fonts.spec: W: no-cleaning-of-buildroot %clean
oflb-asana-math-fonts.spec: W: no-buildroot-tag
oflb-asana-math-fonts.spec: W: no-%clean-section
oflb-asana-math-fonts.spec: W: invalid-url Source0:
http://openfontlibrary.org/people/asyropoulos/asyropoulos_-_Asana_Math.otf HTTP
Error 404: Not Found
oflb-asana-math-fonts.src: W: invalid-url URL:
http://openfontlibrary.org/media/files/asyropoulos/219 HTTP Error 404: Not
Found
oflb-asana-math-fonts.src: W: no-cleaning-of-buildroot %install
oflb-asana-math-fonts.src: W: no-cleaning-of-buildroot %clean
oflb-asana-math-fonts.src: W: no-buildroot-tag
oflb-asana-math-fonts.src: W: no-%clean-section
oflb-asana-math-fonts.src: W: invalid-url Source0:
http://openfontlibrary.org/people/asyropoulos/asyropoulos_-_Asana_Math.otf HTTP
Error 404: Not Found
oflb-asana-math-fonts.noarch: W: invalid-url URL:
http://openfontlibrary.org/media/files/asyropoulos/219 HTTP Error 404: Not
Found
oflb-asana-math-fonts.src: W: invalid-url URL:
http://openfontlibrary.org/media/files/asyropoulos/219 HTTP Error 404: Not
Found
oflb-asana-math-fonts.src: W: no-cleaning-of-buildroot %install
oflb-asana-math-fonts.src: W: no-cleaning-of-buildroot %clean
oflb-asana-math-fonts.src: W: no-buildroot-tag
oflb-asana-math-fonts.src: W: no-%clean-section
oflb-asana-math-fonts.src: W: invalid-url Source0:
http://openfontlibrary.org/people/asyropoulos/asyropoulos_-_Asana_Math.otf HTTP
Error 404: Not Found
3 packages and 1 specfiles checked; 0 errors, 18 warnings.

warnings ignorable. 

I'm assuming the package is for F13+, otherwise you need to add the clean
section.

Please fix that. Rest is OK.


XXX Approved XXX

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.