[Bug 226060] Merge Review: libwpd

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226060

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tomspur at fedoraproject.org
         AssignedTo|nobody at fedoraproject.org    |tomspur at fedoraproject.org
               Flag|                            |fedora-review?

--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org> 2010-07-19 08:57:28 EDT ---
$ rpmlint ./libwpd-0.8.14-4.fc13.src.rpm x86_64/libwpd-*
libwpd-tools.x86_64: W: spelling-error %description -l en_US html -> HTML, ht
ml, ht-ml
libwpd-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wpd2text
['/usr/lib64']
libwpd-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wpd2html
['/usr/lib64']
libwpd-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wpd2raw
['/usr/lib64']
libwpd-tools.x86_64: W: no-documentation
libwpd-tools.x86_64: W: no-manual-page-for-binary wpd2raw
libwpd-tools.x86_64: W: no-manual-page-for-binary wpd2html
libwpd-tools.x86_64: W: no-manual-page-for-binary wpd2text
5 packages and 0 specfiles checked; 3 errors, 5 warnings.

See: https://fedoraproject.org/wiki/Packaging/Guidelines#Removing_Rpath

- please add a %check section (needs BR cppunit-devel):
%check
make check

- in %description tools:
  Could be that there is a '(tm)' missing behind 'WordPerfect', isn't it?
  (Same in main package)


Anything else looks ok:
- name ok
- license ok
- group ok
- libs correctly installed
- no locales
- no static libs
- parallel make
- %files ok
- subpackages require main package implicitely
- no *.la

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.