[Bug 616177] Review Request: eazykeyboard - A simple onscreen keyboard
bugzilla at redhat.com
bugzilla at redhat.com
Tue Jul 20 02:28:03 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=616177
--- Comment #1 from Randall Berry <randyn3lrx at gmail.com> 2010-07-19 22:28:02 EDT ---
================================
Key:
[P] Pass
[F] Fail
[-] Not applicable
[?] Questions (see comments)
================================
[F] MUST: rpmlint must be run on every package. The output should be
posted in the review.
eazykeyboard.spec: W: invalid-url Source0:http://eazykeyboard.
googlecode.com/files /eazykeyboard_2.0.orig.tar.gz HTTP Error
404: Not Found
eazykeyboard.i686: W: spurious-executable-perm /usr/share/doc
/eazykeyboard-2.0/AUTHORS
eazykeyboard.i686: W: spurious-executable-perm /usr/share/doc
/eazykeyboard-2.0/README
eazykeyboard.i686: W: spurious-executable-perm /usr/share/doc
/eazykeyboard-2.0/COPYING
eazykeyboard.i686: W: no-manual-page-for-binary eazykeyboard
eazykeyboard-debuginfo.i686: W: spurious-executable-perm /usr/src
/debug/eazykeyboard-2.0.orig/src/keycodes.c
eazykeyboard-debuginfo.i686: W: spurious-executable-perm /usr/src
/debug/eazykeyboard-2.0.orig/src/main.c
eazykeyboard-debuginfo.i686: W: spurious-executable-perm /usr/src
/debug/eazykeyboard-2.0.orig/src/support.c
eazykeyboard-debuginfo.i686: W: spurious-executable-perm /usr/src
/debug/eazykeyboard-2.0.orig/src/callbacks.c
eazykeyboard-debuginfo.i686: W: spurious-executable-perm /usr/src
/debug/eazykeyboard-2.0.orig/src/loadLanguage.c
ezykeyboard-debuginfo.i686: W: spurious-executable-perm /usr/src
/debug/eazykeyboard-2.0.orig/src/loadLanguage.h
eazykeyboard-debuginfo.i686: W: spurious-executable-perm /usr/src
/debug/eazykeyboard-2.0.orig/src/interface.c
eazykeyboard-debuginfo.i686: W: spurious-executable-perm /usr/src
/debug/eazykeyboard-2.0.orig/src/kboard.h
eazykeyboard-debuginfo.i686: W: spurious-executable-perm /usr/src
/debug/eazykeyboard-2.0.orig/src/kboard.c
eazykeyboard-debuginfo.i686: E: backup-file-in-package /usr/src
/debug/eazykeyboard-2.0.orig
eazykeyboard.src: W: invalid-url Source0: http://eazykeyboard.
googlecode.com/files/eazykeyboard_2.0.orig.tar.gz HTTP Error
404: Not Found
eazykeyboard.i686: W: spurious-executable-perm /usr/share/doc
/eazykeyboard-2.0/AUTHORS
eazykeyboard.i686: W: spurious-executable-perm /usr/share/doc
/eazykeyboard-2.0/README
eazykeyboard.i686: W: spurious-executable-perm /usr/share/doc
/eazykeyboard-2.0/COPYING
eazykeyboard.i686: W: no-manual-page-for-binary eazykeyboard
4 packages and 1 specfiles checked; 1 errors, 18 warnings.
eazykeyboard.src: W: invalid-url Source0: http://eazykeyboard.
googlecode.com/files/eazykeyboard_2.0.orig.tar.gz HTTP Error 404:
Not Found
False positive. URL works in browser.
eazykeyboard.i686: W: no-manual-page-for-binary eazykeyboard
Can be ignored
eazykeyboard-debuginfo.i686: E: backup-file-in-package /usr/src
/debug/eazykeyboard-2.0.orig
I have no clue what this error means. I have never seen it before.
My guess is that it does not like the directory structure of the debug
file and thinks that /eazykeyboard-2.0.orig is a backup when it's not.
[P] MUST: The package must be named according to the Package Naming
Guidelines.
[P] MUST: The spec file name must match the base package %{name},
in the format %{name}.spec unless your package has an exemption.
[P] MUST: The package must meet the Packaging Guidelines.
[F] MUST: The package must be licensed with a Fedora approved
license and meet the Licensing Guidelines.
COPYING file in source claims GPLv2 install.sh claims MIT other source
files claim GPLv2+. License should be GPLv2+ and MIT
[P] MUST: The License field in the package spec file must match
the actual license.
[P] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of
the license(s) for the package must be included in %doc.
[P] MUST: The spec file must be written in American English.
[P] MUST: The spec file for the package MUST be legible.
[P] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for
this task. If no upstream URL can be specified for this package,
please see the Source URL Guidelines for how to deal with this.
4290dfc03c01a3ddf2341c96635894cb eazykeyboard_2.0.orig.tar.gz
4290dfc03c01a3ddf2341c96635894cb eazykeyboard_2.0.orig.tar.gz(2)
[P] MUST: The package MUST successfully compile and build into binary
rpms on at least one primary architecture.
http://koji.fedoraproject.org/koji/taskinfo?taskID=2330002
[-] MUST: If the package does not successfully compile, build or work on
an architecture, then those architectures should be listed in the spec
in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug
filed in bugzilla, describing the reason that the package does not
compile/build/work on that architecture. The bug number MUST be
placed in a comment, next to the corresponding ExcludeArch line.
[P] MUST: All build dependencies must be listed in BuildRequires,
except for any that are listed in the exceptions section of the
Packaging Guidelines ; inclusion of those as BuildRequires is
optional. Apply common sense.
[-] MUST: The spec file MUST handle locales properly. This is done by
using the %find_lang macro. Using %{_datadir}/locale/[ ] is strictly
forbidden.
[-] MUST: Every binary RPM package (or sub package) which stores shared
library files (not just symlinks) in any of the dynamic linker's
default paths, must call ldconfig in %post and %postun.
[P] MUST: If the package is designed to be relocatable, the packager
must state this fact in the request for review, along with the
rationalization for relocation of that specific package.
Without this, use of Prefix: /usr is considered a blocker.
[P] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which
does create that directory. Refer to the Guidelines for examples.
[P] MUST: A package must not contain any duplicate files in the %files
listing.
[F] MUST: Permissions on files must be set properly. Executables should
be set with executable permissions, for example. Every %files section
must include a %defattr(...) line.
eazykeyboard.i686: W: spurious-executable-perm /usr/share/doc
/eazykeyboard-2.0/AUTHORS
eazykeyboard.i686: W: spurious-executable-perm /usr/share/doc
/eazykeyboard-2.0/README
eazykeyboard.i686: W: spurious-executable-perm /usr/share/doc
/eazykeyboard-2.0/COPYING
eazykeyboard-debuginfo.i686: W: spurious-executable-perm /usr/src
/debug/eazykeyboard-2.0.orig/src/keycodes.c
eazykeyboard-debuginfo.i686: W: spurious-executable-perm /usr/src
/debug/eazykeyboard-2.0.orig/src/main.c
eazykeyboard-debuginfo.i686: W: spurious-executable-perm /usr/src
/debug/eazykeyboard-2.0.orig/src/support.c
eazykeyboard-debuginfo.i686: W: spurious-executable-perm /usr/src
/debug/eazykeyboard-2.0.orig/src/callbacks.c
eazykeyboard-debuginfo.i686: W: spurious-executable-perm /usr/src
/debug/eazykeyboard-2.0.orig/src/loadLanguage.c
eazykeyboard-debuginfo.i686: W: spurious-executable-perm /usr/src
/debug/eazykeyboard-2.0.orig/src/loadLanguage.h
eazykeyboard-debuginfo.i686: W: spurious-executable-perm /usr/src
/debug/eazykeyboard-2.0.orig/src/interface.c
eazykeyboard-debuginfo.i686: W: spurious-executable-perm /usr/src
/debug/eazykeyboard-2.0.orig/src/kboard.h
eazykeyboard-debuginfo.i686: W: spurious-executable-perm /usr/src
/debug/eazykeyboard-2.0.orig/src/kboard.c
[P] MUST: The %clean section is not required for F-13 and above. Each package
for F-12 and below (or EPEL) MUST have a %clean section, which contains
rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
[?] MUST: Each package must consistently use macros, as described in the
macros section of Packaging Guidelines.
Consider using macros in %files section as well
%{_bindir}/eazykeyboard should be %{_bindir}/%{name}
%{_datadir}/eazykeyboard/ should be %{_datadir}/%{name}/
[P] MUST: The package must contain code, or permissible content.
This is described in detail in the code vs. content section
of Packaging Guidelines.
[-] MUST: Large documentation files should go in a -doc sub package.
(The definition of large is left up to the packager's best judgement,
but is not restricted to size. Large can refer to either size or quantity)
[P] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program
must run properly if it is not present.
[-] MUST: Header files must be in a -devel package.
[-] MUST: Static libraries must be in a -static package.
[-] MUST: Packages containing pkgconfig(.pc) files must 'Requires:
pkgconfig' (for directory ownership and usability).
[-] MUST: If a package contains library files with a suffix
(e.g. libfoo.so.1.1), then library files that end in .so
(without suffix) must go in a -devel package.
[-] MUST: In the vast majority of cases, devel packages must require
the base package using a fully versioned dependency: Requires:
%{name} = %{version}-%{release}
[-] MUST: Packages must NOT contain any .la libtool archives,
these should be removed in the spec.
[?] MUST: Packages containing GUI applications must include a
%{name}.desktop file,and that file must be properly installed
with desktop-file-install in the %install section. This is described
in detail in the desktop files section of the Packaging Guidelines.
If you feel that your packaged GUI application does not need a .desktop
file, you must put a comment in the spec file with your explanation.
--Vendor tag is obsolete. I don't see anywhere in the source that
includes this tag that is should need a change. Even though the value
is null in the spec consider removing it entirely.
Desktop icon is named onscreenkeyboard.png consider renaming it to
eazykeyboard.png for easy identification with application it represents.
[P] MUST: Packages must not own files or directories already owned by
other packages. The rule of thumb here is that the first package
to be installed should own the files or directories that other packages
may rely upon. This means, for example, that no package in Fedora should
ever share ownership with any of the files or directories owned by the
file system or man package. If you feel that you have a good reason to
own a file or directory that another package owns, then please present
that at package review time.
[P] MUST: At the beginning of %install, each package MUST run
rm -rf %{buildroot} ( or $RPM_BUILD_ROOT ).
See Preping BuildRoot For %install for details. (For EPEL Only)
[P] MUST: All file names in rpm packages must be valid UTF-8.
SHOULD Items:
[P] Should build in mock.
[P] Should build on all supported archs
[P] Should function as described.
[-] Should have sane scriptlets.
[-] Should have sub packages require base package with fully versioned depend.
[P] Should have dist tag
[P] Should package latest version
[P] Check for outstanding bugs on package. (For core merge reviews)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list