[Bug 601577] Review Request: liblockfile - This library implements a number of functions found in -lmail on SysV systems

bugzilla at redhat.com bugzilla at redhat.com
Tue Jul 20 10:44:34 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601577

Matthias Runge <mrunge at matthias-runge.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|601585, 602587              |

--- Comment #8 from Matthias Runge <mrunge at matthias-runge.de> 2010-07-20 06:44:31 EDT ---
Pavel,

I have taken the description from original package description mentioning
"-lmail".

I have uploaded a new version
Spec URL: http://www.matthias-runge.de/fedora/liblockfile.spec
SRPM URL: http://www.matthias-runge.de/fedora/liblockfile-1.08-3.fc13.src.rpm   

I've corrected the exlude for -devel package, excluded statically linked lib,
removed the dependency to perl packages from review request.

[mrunge at mrungexp SPECS]$ rpmlint
/home/mrunge/rpmbuild/SRPMS/liblockfile-1.08-3.fc13.src.rpm
/home/mrunge/rpmbuild/RPMS/i686/liblockfile-1.08-3.fc13.i686.rpm
/home/mrunge/rpmbuild/RPMS/i686/liblockfile-devel-1.08-3.fc13.i686.rpm
/home/mrunge/rpmbuild/RPMS/i686/liblockfile-debuginfo-1.08-3.fc13.i686.rpm

liblockfile.src: W: spelling-error Summary(en_US) lmail -> mail, email, l mail
liblockfile.src: W: spelling-error %description -l en_US lmail -> mail, email,
l mail
liblockfile.src: W: spelling-error %description -l en_US lockfiles -> lock
files, lock-files, lockboxes
liblockfile.i686: W: spelling-error Summary(en_US) lmail -> mail, email, l mail
liblockfile.i686: W: spelling-error %description -l en_US lmail -> mail, email,
l mail
liblockfile.i686: W: spelling-error %description -l en_US lockfiles -> lock
files, lock-files, lockboxes
liblockfile-devel.i686: W: spelling-error Summary(en_US) libs -> lobs, lib, lis
liblockfile-devel.i686: W: spelling-error %description -l en_US libs -> lobs,
lib, lis
4 packages and 0 specfiles checked; 0 errors, 8 warnings.

The included file COPYRIGHT lists the different licenses for both, liblockfile
and dotlockfile. Also, I have contacted the original author for explanation.

I've changed usage of %{__rm} and rm (and also other commands) to beconsistent
without %{__...}.

Regarding the name, I'm currently unsure, what to do. This package is an
adoption of a debian package, containing both, devel-part and dotlockfile. I
think it's really ugly to separate them (because they are maintained both in
one tarball). The tarball is named liblockfile, so I would prefer to name the
fedora package liblockfile.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list