[Bug 581220] Review Request: qtsingleapplication - Qt library to start applications only once per user

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581220

Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?                   |

--- Comment #22 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com> 2010-07-20 19:42:03 EDT ---
Hi Christophe,
Yes you are right. Kalev pointed out this issue in comment #9. Currently beth
qtsingleapplication and qtsinglecoreapplication symbols are in the file
   libQtSolutions_SingleApplication-2.6.so.1.0.0
which links to QtGui, which means anything that uses qtsinglecoreapplication
will drag in QtGui library and all its dependencies. We didn't split
qtsinglecoreapplication, because no other application was using it.

But if there is need, sure, we will split them into different .so files.

However, I believe the qtsinglecoreapplication.prf file should contain
INCLUDEPATH *= $$QMAKE_INCDIR_QT/QtSolutions
DEPENDPATH  *= $$QMAKE_INCDIR_QT/QtSolutions
LIBS *= -lQtSolutions_SingleCoreApplication-2.6
QT *= network

so that you can link to the correct .so file. If you don't link to anything,
you will get missing symbols, as in here: http://fpaste.org/AbgK/

Is it okay for you if we do it this way? Kalev, what is your take on this?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.