[Bug 226457] Merge Review: system-config-httpd

bugzilla at redhat.com bugzilla at redhat.com
Wed Jul 21 05:01:25 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226457

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-07-21 01:01:23 EDT ---
1) rpmlint reported

system-config-httpd.src:16: W: unversioned-explicit-obsoletes apacheconf
system-config-httpd.src:17: W: unversioned-explicit-provides apacheconf
system-config-httpd.src:18: W: unversioned-explicit-obsoletes
redhat-config-httpd
system-config-httpd.src:19: W: unversioned-explicit-provides
redhat-config-httpd
==> These are old names now. Can these be removed? See
http://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages#Do_I_need_to_Provide_my_old_package_names.3F


system-config-httpd.src: W: invalid-url Source0:
system-config-httpd-1.5.2.tar.gz
==> Add comment in SPEC like
This is internally maintained project by Red Hat.

system-config-httpd.noarch: E: explicit-lib-dependency libglade2
== >ok

system-config-httpd.noarch: W: self-obsoletion apacheconf obsoletes apacheconf
system-config-httpd.noarch: W: self-obsoletion redhat-config-httpd obsoletes
redhat-config-httpd
==> Remove these from SPEC

system-config-httpd.noarch: W: conffile-without-noreplace-flag
/etc/alchemist/namespace/system-config-httpd/rpm.adl
system-config-httpd.noarch: E: non-readable
/etc/alchemist/namespace/system-config-httpd/rpm.adl 0600L
system-config-httpd.noarch: E: non-readable
/etc/alchemist/switchboard/system-config-httpd.switchboard.adl 0600L
==> If this is intended, can comments be added why noreplace flag and 600
permission needed?

system-config-httpd.noarch: E: non-executable-script
/usr/share/system-config-httpd/ForgeBlackBox.py 0644L /usr/bin/python
system-config-httpd.noarch: E: non-executable-script
/usr/share/system-config-httpd/ApacheControl.py 0644L /usr/bin/python
system-config-httpd.noarch: E: non-executable-script
/usr/share/system-config-httpd/CacheBlackBox.py 0644L /usr/bin/python
system-config-httpd.noarch: E: non-executable-script
/usr/share/system-config-httpd/FileBlackBox.py 0644L /usr/bin/python
system-config-httpd.noarch: E: non-executable-script
/usr/share/system-config-httpd/PyAlchemist.py 0644L /usr/bin/python
system-config-httpd.noarch: E: non-executable-script
/usr/share/system-config-httpd/URLBlackBox.py 0644L /usr/bin/python
system-config-httpd.noarch: E: non-executable-script
/usr/share/system-config-httpd/CheckList.py 0644L /usr/bin/python
system-config-httpd.noarch: E: non-executable-script
/usr/share/system-config-httpd/ApacheConf.py 0644L /usr/bin/python
system-config-httpd.noarch: E: non-executable-script
/usr/share/system-config-httpd/Alchemist.py 0644L /usr/bin/python
system-config-httpd.noarch: E: non-readable
/etc/alchemist/namespace/system-config-httpd/local.adl 0600L
system-config-httpd.noarch: E: non-executable-script
/usr/share/system-config-httpd/ApacheGizmo.py 0644L /usr/bin/python
==>
http://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries

system-config-httpd.noarch: W: dangerous-command-in-%pre mv
system-config-httpd.noarch: W: dangerous-command-in-%preun rm
==> Is this needed here?

2)timestamps should be preserved.Use INSTALL="install -p" when installing to
preserve timestamps.

3) I will suggest this pacakge to follow current packaging guidelines and
remove buildroot, %clean section and cleaning of build root in %install

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the package-review mailing list