[Bug 226473] Merge Review: system-switch-mail

bugzilla at redhat.com bugzilla at redhat.com
Wed Jul 21 05:06:42 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226473

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-07-21 01:06:41 EDT ---
Ah! package has latest update in F-12 but not in F-13 and devel.

Please first build latest release in F-13 and devel

Also,
1) remove old Obsoletes and Provides from spec. See
http://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages#Do_I_need_to_Provide_my_old_package_names.3F


2)timestamps should be preserved.Use INSTALL="install -p" when installing to
preserve timestamps.

3) I will suggest this pacakge to follow current packaging guidelines and
remove buildroot, %clean section and cleaning of build root in %install    

4) Don't use makeinstall See
https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

5) Please follow
https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the package-review mailing list