[Bug 592670] Review Request: mongoose - An easy-to-use self-sufficient web server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592670

Toshio Ernie Kuratomi <a.badger at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #25 from Toshio Ernie Kuratomi <a.badger at gmail.com> 2010-07-21 15:28:47 EDT ---
Good:
* Package is named mongoose which follows the upstream project name
* spec file naming follows package naming
* License in spec and sources is MIT which is open source
* No license text included in the tarball so no need to include one.
* Spec is legible and American English
* http://mongoose.googlecode.com/files/mongoose-2.8.tgz
* Source matches upstream
* No locale files
* No shared libraries
* No bundled libraries
* Not relocatable
* No directories created unowned
* No duplicate files
* Default permissions are set
* Package is code
* No large documentation
* No %doc files are used at runtime
* No header files
* Not a GUI application
* Does not own files or directories from other packages
* All filenames are utf8
* Patch files both have upstream issues opened and look good for our purposes
* Builds in koji  (See Needswork below for one change that I implemented when
building in koji)
* rpmlint is clean:
  3 packages and 0 specfiles checked; 0 errors, 0 warnings.
* Ran mongoose on a directory of html files nad it served them up on port 8080

Needswork:
* We can't call rpm from within an rpm spec file since we aren't assured that
  the rpm that created the build environment is compatible with the rpm that
  would be run within the environment.  Here's a different command that would
  work:
  LIBV=$(find '%{_libdir}' | grep -E '/libssl.so.[0-9]?[0-9]?$' | sed -e
's!%{_libdir}/libssl.so.!!')
* Ask upstream to include a license file.

APPROVED

Remember to fix the LIBV line in the spec file before you import and build.

I'm sponsoring you and approving the package.  Feel free to ask me any
questions you have.  I'm abadger1999 on irc.freenode.net (almost always in
#fedora-admin) and toshio [at] fedoraproject.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.