[Bug 603641] Review Request: python-fontMath - A set of objects for performing math operations on font data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603641

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #2 from Thomas Spura <tomspur at fedoraproject.org> 2010-07-22 06:31:33 EDT ---
Review:

Good:
- name ok
- source match upstream: 739ecc87c553180c4978c110230be6f7
- $ rpmlint ./python-fontMath-0.2-1.fc13.src.rpm
noarch/python-fontMath-0.2-1.fc13.noarch.rpm 
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

- no libs
- no locales
- license ok
- macros everywhere
- spec readable




Needswork:
- you should use %{version} in the source url
- you should also buildrequire python-robofab
- wouldn't be Development/Tools be better as a group?

- %files:
  You don't own %{python_sitelib}/fontMath -> remove the '*'


_____________________________________________________________________________

the %files issue is a blocker, the rest SHOULD.
Approving anyway, because I'm sure, you'll change it.

_____________________________________________________________________________

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.