[Bug 603639] Review Request: python-ufo2fdk - A bridge between UFOs and the AFKDO

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603639

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #2 from Thomas Spura <tomspur at fedoraproject.org> 2010-07-22 10:59:59 EDT ---
Review:

Good:
- name ok
- source match upstream:
  bd9d9ea3d41169f3d1f50abbdaa0dbb0
- spec readable
- macros everywhere
- no libs
- no *.la
- no locales
- $ rpmlint ./python-ufo2fdk-0.1-1.fc13.src.rpm
noarch/python-ufo2fdk-0.1-1.fc13.noarch.rpm 
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

- license ok



Needswork:
- %{version} in url
- missing R fonttools

______________________________________________________________________________

Missing R is a BLOCKER, %{verion} in url is SHOULD.
______________________________________________________________________________

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.